Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3350671 by nkoporec: Pager not working in Albums #3361

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

nkoporec
Copy link
Contributor

Problem

Nothing happens when clicking on a pager on Album content type.

Solution

The reason in that the pager id is not correct, we need to set it to 0 (as it is by default)

Issue tracker

https://www.drupal.org/project/social/issues/3350671

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  1. Enable social_album
  2. Create a new album and add at least 13 images (so that the pager is displayed)
  3. View the album and try to use the pager.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

[Required if new feature, and if applicable] If this Pull Request makes visual changes then please include some screenshots that show what has changed here. A before and after screenshot helps the reviewer determine what changes were made.

Release notes

Fixed broken pagination on album content type.

Change Record

[Required if applicable] If this Pull Request changes the way that developers should do things or introduces a new API for developers then a change record to document this is needed. Please provide a draft for a change record or a link to an unpublished change record below. Existing change records can be consulted as example. Please provide a draft for a change record or a link to an unpublished change record below. Existing change records can be consulted as example.

Translations

[Optional]Translatable strings are always extracted from the latest development branch. To ensure translations remain available for platforms running older versions of Open Social the original string should be added to translations.php when it's changed or removed.

  • Changed or removed source strings are added to the translations.php file.

@nkoporec nkoporec added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels Mar 27, 2023
@nkoporec nkoporec added this to the 11.6.9 milestone Mar 27, 2023
@mergeable
Copy link

mergeable bot commented Mar 27, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@robertragas robertragas self-requested a review March 28, 2023 12:24
@robertragas robertragas merged commit e4fe40e into main Mar 28, 2023
@robertragas robertragas deleted the bug/issue-3350671-pager-not-working-in-albums branch March 28, 2023 12:28
robertragas added a commit that referenced this pull request Mar 28, 2023
…-working-in-albums

Issue #3350671 by nkoporec: Pager not working in Albums
robertragas added a commit that referenced this pull request Mar 28, 2023
…-working-in-albums

Issue #3350671 by nkoporec: Pager not working in Albums
robertragas added a commit that referenced this pull request Mar 28, 2023
…-working-in-albums

Issue #3350671 by nkoporec: Pager not working in Albums
@robertragas robertragas added backport: verified This pull request has been back ported to an older minor version status: no action needed and removed status: needs review This pull request is waiting for a requested review labels Mar 28, 2023
@robertragas
Copy link
Contributor

Reviewed, approved, and cherry picked to 11.6.x, 11.7.x and 11.8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium team: guardians type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

2 participants