Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3373172 by tbsiqueira: Update our tugboat docker image with one supporting PHP 8.1 #3460

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

tbsiqueira
Copy link
Contributor

@tbsiqueira tbsiqueira commented Jul 7, 2023

🚀 🔥 Related PRs 🔥 🚀

This is a PR from a series of 5 PRs that should be merged in the following order:

  1. Issue #3373075 by tbsiqueira: Update dev/test dependencies open_social_dev#70
  2. Issue #3373172 by tbsiqueira: Update our tugboat docker image with one supporting PHP 8.1 #3460
  3. Issue #3373075 by tbsiqueira: Update from drupal/core-recommended to drupal/core #3457
  4. Update our Doocker setup to use PHP 8.1 images drupal_social#392 ( this is just a private repository that we use for development, this will not be available for public users )
  5. Issue #3368689 by tbsiqueira: Update behat tests to use the new compatible php 8.1 images #3439

They are ALL BC and should not cause any breaking change for our local development

Problem

Since we are moving to PHP 8.1, we should update our tugboat docker image

Solution

Use the new available image from here https://github.com/goalgorilla/ci_images/pkgs/container/ci-tugboat-php

Issue tracker

https://www.drupal.org/project/social/issues/3373172

Theme issue tracker

N/A

How to test

  • Open Social is running on tugboat and PHP 8.1

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

N/A

Change Record

N/A

Translations

N/A

@tbsiqueira tbsiqueira added this to the 11.10.0-alpha1 milestone Jul 7, 2023
@mergeable
Copy link

mergeable bot commented Jul 7, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@tbsiqueira tbsiqueira added status: needs review This pull request is waiting for a requested review prio: high type: dependencies Updating a dependency file needs: test team: guardians and removed blocked: mergeable labels Jul 7, 2023
@tbsiqueira tbsiqueira changed the title Update out tugboat docker image with one supporting PHP 8.1 Issue #3373172 by tbsiqueira: Update out tugboat docker image with one supporting PHP 8.1 Jul 7, 2023
@tbsiqueira tbsiqueira changed the title Issue #3373172 by tbsiqueira: Update out tugboat docker image with one supporting PHP 8.1 Issue #3373172 by tbsiqueira: Update our tugboat docker image with one supporting PHP 8.1 Jul 7, 2023
@zanvidmar zanvidmar self-requested a review July 10, 2023 11:48
Copy link
Contributor

@zanvidmar zanvidmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: check tugboat again after alpha release

@tbsiqueira tbsiqueira merged commit bcc3f98 into main Jul 10, 2023
190 checks passed
@tbsiqueira tbsiqueira deleted the issue/PROD-25688-update-tugboat-image-to-php-8-1 branch July 10, 2023 12:07
@navneet0693 navneet0693 removed status: needs review This pull request is waiting for a requested review needs: test labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants