Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3406822 by nkoporec: Deprecate and remove social_lets_connect_usage #3636

Conversation

nkoporec
Copy link
Contributor

@nkoporec nkoporec commented Dec 7, 2023

Problem

The module social_lets_connect_usage needs to be marked as deprecated and will be removed in a next major version.

This module functionality is no longer in use, so we can deprecate it.

Solution

Write an update hook to uninstall the module and remove the configs, deprecate the module in .info.yml file.

Issue tracker

https://www.drupal.org/project/social/issues/3406822

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  • Set up Open Social from the main branch
  • Checkout this branch
  • Run update hooks
  • Make sure the module is uninstalled.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

The module social_lets_connect_usage has been marked as deprecated and will be removed in the next major release.

Change Record

The module social_lets_connect_usage has been marked as deprecated and will be removed in the next major release.

Translations

@nkoporec nkoporec added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels Dec 7, 2023
@nkoporec nkoporec added this to the 12.0.0-rc7 milestone Dec 7, 2023
Copy link

mergeable bot commented Dec 7, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@nkoporec nkoporec force-pushed the issue/3406822/deprecate-and-remove-social-lets-connect-usage-module branch 2 times, most recently from 094f387 to d316a4d Compare December 7, 2023 16:35
@ronaldtebrake ronaldtebrake modified the milestones: 12.0.0-rc7, 12.0.1 Dec 8, 2023
@ronaldtebrake ronaldtebrake force-pushed the issue/3406822/deprecate-and-remove-social-lets-connect-usage-module branch from d316a4d to 43109ec Compare December 8, 2023 10:42
@robertragas robertragas self-requested a review December 11, 2023 12:11
@robertragas robertragas added status: no action needed and removed status: needs review This pull request is waiting for a requested review labels Dec 11, 2023
@robertragas
Copy link
Contributor

Approved

@robertragas robertragas merged commit dec23e2 into main Dec 11, 2023
187 checks passed
@robertragas robertragas deleted the issue/3406822/deprecate-and-remove-social-lets-connect-usage-module branch December 11, 2023 12:12
@ronaldtebrake ronaldtebrake modified the milestones: 12.0.1, 12.0.2 Dec 23, 2023
@ronaldtebrake ronaldtebrake added the backport: verified This pull request has been back ported to an older minor version label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium team: guardians type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

3 participants