Issue #3415090 by nkoporec: SocialProfileTagSplitWidget is not being rendered if the #options is empty

[nkoporec]

Problem

We want to programetically render a form that contains that uses the SocialProfileTagSplitWidget widget, the #options array is populated later (after rendering the initial form). The problem is that the field is not being rendered correctly as within the widget we are returning an empty array if there are no #options. I think this should not be the case and the widget should return the basic structure of the element.

Solution

Don't return an empty array if the #options are empty but rather return the already build element array.

Issue tracker

https://www.drupal.org/project/social/issues/3415090

Theme issue tracker

How to test

1. Create a form that uses SocialProfileTagSplitWidget
2. Try to render the form programetically but don't populate the #options of the widget.
3. Render the form and check if the widget is rendered.

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Change Record

Fixed an issue with SocialProfileTagSplitWidget when the widget was not being rendered correctly if the #options were empty.

Translations

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[BiaInacio]

Organization tag and interests fields are working as expected on registration form!

[vcsvinicius]

I Approved

[nkoporec]

🍒 picked to 12.0.x, 12.1.x and 12.2.x