Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates: (deps): Update drupal/address requirement from 2.0.0 to 2.0.1 #3786

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 20, 2024

Problem

The Address module has a new small version.

Solution

Update the Address module to new major version, but add option to be compatible with 1.2 version as well.

Issue tracker

PROD-28460
#3426396

Theme issue tracker

N/A

How to test

N/A

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

Address release notes: https://www.drupal.org/project/address/releases/2.0.1

Change Record

N/A

Translations

N/A


Updates the requirements on drupal/address to permit the latest version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: update labels Feb 20, 2024
@dependabot dependabot bot requested a review from a team February 20, 2024 00:09
@dependabot dependabot bot force-pushed the dependabot/composer/drupal/address-2.0.1 branch from 401f57d to ecc432c Compare March 1, 2024 07:53
@ronaldtebrake
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/composer/drupal/address-2.0.1 branch from 0008cb9 to b879daa Compare March 6, 2024 08:13
@vcsvinicius
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 7, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Updates the requirements on drupal/address to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/address
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@vcsvinicius vcsvinicius force-pushed the dependabot/composer/drupal/address-2.0.1 branch from b8a1be4 to 5c84a51 Compare March 7, 2024 14:08
composer.json Outdated Show resolved Hide resolved
@vcsvinicius vcsvinicius force-pushed the dependabot/composer/drupal/address-2.0.1 branch from 5c84a51 to 45f205a Compare March 7, 2024 14:45
@vcsvinicius vcsvinicius force-pushed the dependabot/composer/drupal/address-2.0.1 branch from 45f205a to 780bd84 Compare March 7, 2024 14:47
@vcsvinicius vcsvinicius requested review from vcsvinicius and removed request for a team March 7, 2024 14:48
@vcsvinicius vcsvinicius added this to the 12.3.0 milestone Mar 7, 2024
Copy link
Contributor

@vcsvinicius vcsvinicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved and tested locally

@ronaldtebrake ronaldtebrake modified the milestones: 12.3.0, 13.0.0 Mar 7, 2024
@vcsvinicius vcsvinicius merged commit 7d2f63e into main Mar 7, 2024
187 checks passed
@vcsvinicius vcsvinicius deleted the dependabot/composer/drupal/address-2.0.1 branch March 7, 2024 15:42
@ronaldtebrake ronaldtebrake modified the milestones: 13.0.0, 13.0.0-alpha1 Apr 23, 2024
@Kingdutch Kingdutch added type: dependencies Updating a dependency file and removed type: update labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: dependencies Updating a dependency file
3 participants