Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates: (deps): Update drupal/graphql requirement from 4.6.0 to 4.7.0 #3828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 22, 2024

Updates the requirements on drupal/graphql to permit the latest version.

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: update labels Mar 22, 2024
@dependabot dependabot bot requested a review from a team March 22, 2024 00:53
@vcsvinicius
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/composer/drupal/graphql-4.7.0 branch from eac1769 to 210cb6c Compare April 3, 2024 18:05
@vcsvinicius
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/composer/drupal/graphql-4.7.0 branch from 210cb6c to 270492e Compare April 4, 2024 12:46
@ronaldtebrake
Copy link
Contributor

The issues in GraphQL\Error\SyntaxError: Syntax Error: Expected Name, found }

Seem to be related to our OpenSocialBaseSchema (open_social.graphqls) where we have empty types for Subscription and Mutation (which we later want to extend) instead of duplicating in all other schemas.

This used to work, but given the new performance improvements released drupal-graphql/graphql@8.x-4.6...8.x-4.7#diff-47d35112ac06840fef6a074131bb2728bc25f122d65d21ed96b58d93c2fdd8c3L138

It's now considered invalid schema.

Seems to be related to the spec as well where empty types aren't allowed, although one could argue that because we use a modular approach we're extending them further down the line so whether or not its empty after all:
graphql/graphql-spec#568
graphql/graphql-spec#606

Updates the requirements on drupal/graphql to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/graphql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/composer/drupal/graphql-4.7.0 branch from 270492e to efd8598 Compare April 15, 2024 20:55
@Kingdutch Kingdutch added type: dependencies Updating a dependency file and removed type: update labels Apr 30, 2024
Copy link

Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them.

Missing milestone
The issue is missing a milestone. Milestones are important to help release managers know whether they might need to postpone a release for a critical issue and to communicate what fixes and new features are included in a release. Before merging, please select the appropriate milestone for this pull request.

🤖 This is an automatically produced message by the Open Social PR manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: dependencies Updating a dependency file
3 participants