Issue #3433028: Some menus are showing to the user without permission

[vcsvinicius]

Problem

After #3418484 some menus start to show to user without permission.

Solution

Add validation to check permission to the menu.

Issue tracker

PROD-28618
#3433028

Theme issue tracker

N/A

How to test

Make test with diferent roles to check the permissions

1. Notification Center

• Go to the any page as logged user
• Change the visualization to mobile
• Click on user menu on header bar
• Check if there has "Notification Center" option and click on it

2. Social Album

• Enable Social Album module
• Go to the any page as logged user
• Click on plus menu on header bar
• Check if there has "New Album" option and click on it
• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "My albuns" option and click on it

3. Social Book

• Enable Social Book module
• Go to the any page as logged user
• Click on plus menu on header bar
• Check if there has "New Book Page" option and click on it

4. Invites

• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "Invites" option and click on it

5. Social Events

• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "My events" option and click on it
• Go to the any page as logged user
• Click on plus menu on header bar
• Check if there has "Add Event" option and click on it

6. Social Follow Content

• Enable Social Follow Content module
• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "Following" option and click on it

7. Social Follow Taxonomy Term

• Enable Social Follow Taxonomy Term module
• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "Following tags" option and click on it

8. Social Group

• Go to the any page as logged user
• Click on plus menu on header bar
• Check if there has "New Group" option and click on it
• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "My groups" option and click on it

9. Social Landing Page

• Enable Social Landing Page module
• Go to the any page as logged user
• Click on plus menu on header bar
• Check if there has "New Landing Page" option and click on it

10. Social Page

• Go to the any page as logged user
• Click on plus menu on header bar
• Check if there has "New Page" option and click on it

11. Social Private Message

• Enable Social Private Message module
• Change the visualization to mobile
• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "Inbox" option and click on it

12. Social Profile

• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "My profile" and "Edit profile" option and click on it

13. Social Topic

• Go to the any page as logged user
• Click on user menu on header bar
• Check if there has "My topics" option and click on it
• Go to the any page as logged user
• Click on plus menu on header bar
• Check if there has "Add Topic" option and click on it

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

This will fix menu link showing for user without permissions.

Change Record

N/A

Translations

N/A

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[ronaldtebrake]

Can confirm this works 👍 as CM and VU

[BiaInacio]

All links are working and are displayed as expected, according to the visibility rules.

[ronaldtebrake]

Cherry picked to 12.2.x, 12.3.x, 12.4.x