Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3452660: Grequest compatibility with group v2 #3920

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

robertragas
Copy link
Contributor

@robertragas robertragas commented Jun 5, 2024

Problem

When looking at the code of the grequest module in the latest alpha we see there are still issues for it to work with groups v2.

  • Services are not correctly defined.
  • Still reference to old group content relation

Solution

  • Add the correct services definition for the relation.
  • Remove the old unset of permissions as they don't exist anymore in that part.

Note: Even though we don't use all the services such as group operations (we have our own button there) it's good to have it in there for when we want to convert to the contrib grequest.

Issue tracker

https://www.drupal.org/node/3452660

Theme issue tracker

How to test

  • Functional: Go to admin/group/types/manage/flexible_group/permissions and search for the word "Administer membership request" and see it cannot find anything.
  • Set breakpoint in the RelationHandler PermissionProvider and see it won't reach there when going to the url above.
  • Check out to this branch and try again.
  • Also set a breakpoint in the buildPermissions method and see that they unset permissions are not showing because they don't exist there.

Screenshots

Release notes

Internal: Fix for group v2 compatibility for the submodule grequest.

Change Record

Translations

@robertragas robertragas added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: high team: guardians labels Jun 5, 2024
@robertragas robertragas added this to the 13.0.0-alpha5 milestone Jun 5, 2024
- Update the grequest services definition. They need to be the same as the relation itself which is group_membership_request. This means that they were not used before.
- Also remove the unsetting of the PermissionProvider permissions. As you would debug in there, these permissions do not exist there anymore so nothing to unset.
@robertragas robertragas force-pushed the issue/PROD-29752-grequest-groupv2 branch from 8484991 to cd75ceb Compare June 5, 2024 11:26
Copy link
Contributor

@vcsvinicius vcsvinicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved

@BiaInacio
Copy link
Contributor

Permission is not displayed!
image

@robertragas robertragas removed the status: needs review This pull request is waiting for a requested review label Jun 7, 2024
@robertragas robertragas merged commit a77761c into main Jun 7, 2024
189 checks passed
@robertragas robertragas deleted the issue/PROD-29752-grequest-groupv2 branch June 7, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants