Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-29886: Behat tests for visibilities and comments #3985

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

SonikaBM
Copy link
Contributor

@SonikaBM SonikaBM commented Jul 23, 2024

Problem

  1. There were no Behat tests that ensure the visibilities for topics and events work as expected for different roles
  2. There was no Behat test to validate hidden settings for comments

Solution

  1. Create tests to validate all visibilities in topic and event overview and accessibility of the content via direct link to ensure:
  • Only public entities are accessible to anonymous and unverified users
  • Only public and community entities are accessible to verified user
  • All entities are accessible to content manager
  • Group entities are accessible to verified members of the group
  1. Create test to validate open and hidden settings of comments work as expected

Issue tracker

Theme issue tracker

N/A

How to test

  • New tests are green

Screenshots

Release notes

Adds behat test coverage for topic/events overview content visibility

Change Record

N/A

Translations

N/A

@SonikaBM SonikaBM added team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review prio: medium type: test Adds or improves test coverage without other changes labels Jul 23, 2024
@SonikaBM SonikaBM changed the title Issue/prod 29886 behat tests Prod-29886: Behat tests for visibilities and comments Jul 23, 2024
@SonikaBM SonikaBM added this to the 12.3.6 milestone Jul 23, 2024
@SonikaBM SonikaBM changed the title Prod-29886: Behat tests for visibilities and comments PROD-29886: Behat tests for visibilities and comments Jul 24, 2024
@robertragas robertragas modified the milestones: 12.3.6, 12.3.8 Aug 28, 2024
@volodymyr-sydor volodymyr-sydor marked this pull request as draft September 10, 2024 10:59
@volodymyr-sydor volodymyr-sydor marked this pull request as draft September 10, 2024 10:59
@volodymyr-sydor volodymyr-sydor marked this pull request as draft September 10, 2024 10:59
@volodymyr-sydor volodymyr-sydor removed the status: needs review This pull request is waiting for a requested review label Sep 10, 2024
@volodymyr-sydor volodymyr-sydor force-pushed the issue/prod-29886-behat-tests branch 6 times, most recently from df1551d to 3738584 Compare September 10, 2024 11:45
@volodymyr-sydor volodymyr-sydor force-pushed the issue/prod-29886-behat-tests branch 5 times, most recently from 5444269 to 229fe34 Compare September 10, 2024 12:59
Validate different visibilities for contents for different users
Validate different settings of comments section
@volodymyr-sydor volodymyr-sydor marked this pull request as ready for review September 10, 2024 14:03
@volodymyr-sydor volodymyr-sydor added status: needs review This pull request is waiting for a requested review and removed status: needs work This pull request needs more work before it's ready for review labels Sep 10, 2024
@ribel ribel merged commit 0b6b95d into main Sep 13, 2024
194 of 195 checks passed
@ribel ribel deleted the issue/prod-29886-behat-tests branch September 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: test Adds or improves test coverage without other changes
Development

Successfully merging this pull request may close these issues.

6 participants