Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2973550 by Makishima: Fix redirection to the group after user join #904

Merged
merged 3 commits into from Jun 26, 2018

Conversation

VolodymyrMartsynenko
Copy link
Contributor

@VolodymyrMartsynenko VolodymyrMartsynenko commented Jun 5, 2018

Problem

After joining a Group, the member is directed to their Group page. I would expect them to be directed back to the page they were viewing before clicking to join the Group

Solution

Fix incorrect form id

Issue tracker

HTT

  • Check out the code changes
  • Login as LU, open any group and join
  • Notice that you will be redirected to user groups page
  • Checkout to this branch
  • Open any group and join, you should be directed back to the Group page

@VolodymyrMartsynenko VolodymyrMartsynenko added type: bug Fixes a bug in Open Social support labels Jun 5, 2018
@jaapjan
Copy link
Contributor

jaapjan commented Jun 6, 2018

@VolodymyrMartsynenko please check failing test of:
/var/www/html/profiles/contrib/social/tests/behat/features/capabilities/group/group-create-open.feature:7
https://travis-ci.org/goalgorilla/open_social/jobs/388309184

@jaapjan jaapjan added the status: needs work This pull request needs more work before it's ready for review label Jun 6, 2018
@VolodymyrMartsynenko
Copy link
Contributor Author

Hi @jaapjan I fixed the failed test /var/www/html/profiles/contrib/social/tests/behat/features/capabilities/group/group-create-open.feature

@VolodymyrMartsynenko VolodymyrMartsynenko removed the status: needs work This pull request needs more work before it's ready for review label Jun 7, 2018
@Kingdutch Kingdutch self-requested a review June 11, 2018 14:12
@jaapjan jaapjan modified the milestones: 2.1, 1.18 Jun 13, 2018
@bramtenhove
Copy link
Member

@jaapjan I think we should move this to 2.x. Agreed?

@bramtenhove bramtenhove changed the base branch from 8.x-1.x to 8.x-2.x June 13, 2018 12:16
@bramtenhove bramtenhove modified the milestones: 1.18, 2.1 Jun 13, 2018
@bramtenhove bramtenhove merged commit 241733c into 8.x-2.x Jun 26, 2018
@bramtenhove bramtenhove deleted the feature/2973550-redirect-to-group-after-join branch June 26, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Fixes a bug in Open Social
4 participants