Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2973550 by Makishima: Fix redirection to the group after user join #904

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Issue #2973550 by Makishima: Fix redirection to the group after user join #904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ee395e
Issue #2973550 by Makishima: Fix redirection to the group after user …
VolodymyrMartsynenko Jun 5, 2018
f14261c
Issue #2973550 by Makishima: Fix behat tests
VolodymyrMartsynenko Jun 7, 2018
bf260b3
Merge branch '8.x-2.x' into feature/2973550-redirect-to-group-after-join
bramtenhove Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/social_features/social_group/social_group.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ function _social_group_action_form_submit($form, FormStateInterface $form_state)
// Get form that was submitted.
$complete_form = $form_state->getCompleteForm();

if (in_array($complete_form['#form_id'], ['group_content_' . $group->bundle() . '_membership_group-join_form', 'group_content_' . $group->bundle() . '-group_membership_add_form'])) {
if (in_array($complete_form['#form_id'], ['group_content_' . $group->bundle() . '-group_membership_group-join_form', 'group_content_' . $group->bundle() . '-group_membership_add_form'])) {
// Set redirect to group home page.
$form_state->setRedirect(
'entity.group.canonical',
Expand Down
3 changes: 1 addition & 2 deletions tests/behat/features/capabilities/group/group-create-open.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ Feature: Create Open Group
And I should see the button "Cancel"
And I should see the button "Join group"
And I press "Join group"
And I should see "Test open group"
And I click "Test open group"
And I should see "Test open group" in the "Hero block"
And I should see the button "Joined"

# DS-643 As a LU I want to see the events of a group
Expand Down