Use v4 signatures in SQS for all regions and use aws.Encode instead of url.QueryEscape in v4 signer #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to AWS docs, this should follow RFC-3986, which uses %20 encoding of space characters. However, golang encodes to a + character.
It seems that this is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a branch in the SQS code which meant the v4 signer would only be used in the cn-north-1 region. I don't think this is required any more, so I have removed that branch.
Following this change, the sign function in the sqs package seemed to no longer be used, so I have removed that.
I also noticed that in Canonical URLs, spaces were being encoded to + rather than %20. Using the aws.Encode function seems to resolve this issue.