Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop BaseAdvice class to speed up class initialization #396

Merged
merged 2 commits into from
May 19, 2018
Merged

Drop BaseAdvice class to speed up class initialization #396

merged 2 commits into from
May 19, 2018

Conversation

lisachenko
Copy link
Member

There is no need in extra class BaseAdvice in hierarchy, so all code could be moved to the AbstractInterceptor class. BaseAdvice can be dropped without any pain

@lisachenko lisachenko added this to the 3.x milestone May 18, 2018
@scrutinizer-notifier
Copy link

The inspection completed: 8 updated code elements

@lisachenko lisachenko merged commit efe2568 into master May 19, 2018
@lisachenko lisachenko deleted the feature/optimize-class-hierarchy branch May 19, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCelavi TheCelavi TheCelavi approved these changes

Assignees
No one assigned
Labels
Improvement
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lisachenko @scrutinizer-notifier @TheCelavi