New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RawX and RawY ints in MapLinkPayload #84

Merged

goaaats merged 1 commit into goatcorp:master from rreminy:patch-4

Apr 21, 2020

Contributor

rreminy commented Apr 21, 2020

I found out RawX and RawY because:

The raw coordinates (0, 0) is roughly the middle flag coordinates (21.5, 21.5)
Going a bit to the left (or up) they jump to 4.2 billion (which makes it easy to tell its just the sign bit being set)


          Make RawX and RawY ints in MapLinkPayload

ad9cb25

goaaats merged commit 21da9d8 into goatcorp:master

Contributor

ff-meli commented Apr 21, 2020

@rreminy Using ints for these breaks on some values, which is why it was intentionally done as uints (as the casts should make obvious).

Is there a case where this does not convert to correct values for you?

ff-meli mentioned this pull request

Revert "Make RawX and RawY ints in MapLinkPayload" #85

Merged

goaaats linked an issue

that may be closed by this pull request

Wrong values on some MapLinks #88

Closed

goaaats mentioned this pull request

Wrong values on some MapLinks #88

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment