Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong values on some MapLinks #88

Closed
goaaats opened this issue Apr 21, 2020 · 3 comments · Fixed by #84 or #85
Closed

Wrong values on some MapLinks #88

goaaats opened this issue Apr 21, 2020 · 3 comments · Fixed by #84 or #85
Assignees
Labels
bug Something isn't working plugin-api About or affects the Plugin API

Comments

@goaaats
Copy link
Member

goaaats commented Apr 21, 2020

When the value of RawX and RawY are technically supposed to go into the negative, instead, since they are interpreted as uints, the value shoots up:
image

Steps to reproduce:

  1. Go to Lakeland
  2. Go to X: 20.9 Y: 21.0 Z:0
  3. Send an /e <pos> and log the value of the produced MapLinkPayload

Is this a bug?
This was previously attempted to be fixed by #84.

@goaaats goaaats assigned goaaats and ff-meli and unassigned goaaats Apr 21, 2020
@goaaats goaaats added bug Something isn't working plugin-api About or affects the Plugin API labels Apr 21, 2020
@ff-meli
Copy link
Contributor

ff-meli commented Apr 21, 2020

There is no issue with that - they are raw values, which are essentially only meaningful as a hex/bit pattern. The resolved values will map as expected.

@ff-meli
Copy link
Contributor

ff-meli commented Apr 21, 2020

for instance, those values in your screenshot decode to (20.98374, 21.0252), which in game is then truncated at one decimal to (20.9, 21.0) - exactly the location you specified

@goaaats
Copy link
Member Author

goaaats commented Apr 21, 2020

Alright, thanks for clarifying!

@goaaats goaaats closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin-api About or affects the Plugin API
Projects
None yet
2 participants