segwit starter#30
Merged
Merged
Conversation
Added everything required to function on the Bitcoin Core segregated witness test network
Add recognization of the new input and output types used by segwit
Adds negotiation of witness usage through NODE_WITNESS service bit
Added transaction witness serialization stuff to PyTx. Still not complete.
Block file parsing with witnesses is completely fixed.
goatpig
pushed a commit
that referenced
this pull request
Nov 10, 2017
af2da22 Add new tests for invalid Bech32 strings (Clark Moody) Pull request description: Similar updates in the vein of #27, #29, #30, #31, #32 Adds invalid Bech32 string test cases. Please note: Rust strings are UTF-8, so that the character literal `0xff` [turns into](https://codepoints.net/U+00FF) `0xc3bf` when accessed with the `bytes` function. Tree-SHA512: 73f85762fc22059acb9c4b382068997fb0341354f1de26ecb2d75ba3c57aee80609fd2839967541c9a9f96ccdc04137140174396f5acfe62a6511fd9f18e703e
goatpig
pushed a commit
that referenced
this pull request
Nov 10, 2017
a4e672d Update Haskell tests (Pieter Wuille) Pull request description: Tree-SHA512: 7da982c437be4f424a431a758a478c1c59f12a8369fe44e9fe8759bc227b2090b0a63ddead7c819813b231a26da1be794d68fc3f2dcc8a41d778e7a76de9e4a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a bunch of stuff that I wrote which will help Armory get compatible with the Segregated Witness changes.
Stuff that is done
Stuff that needs to be done in later PRs.