Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segwit starter #30

merged 7 commits into from Mar 30, 2016

segwit starter #30

merged 7 commits into from Mar 30, 2016


Copy link

@achow101 achow101 commented Mar 27, 2016

This PR is a bunch of stuff that I wrote which will help Armory get compatible with the Segregated Witness changes.

Stuff that is done

  • Can access the segwit test network
  • Properly parses the block files produced by a segwit node
  • Adds the NODE_WITNESS service bit so that it receives transactions and blocks with witnesses
  • Some transaction and block serializing and deserialzing has been done

Stuff that needs to be done in later PRs.

  • Fix transactions in the database so that the txid is the actual txid as specified by segwit
  • Send Bitcoin, needs to have the signing code with the new signing algo to deal with segwit outputs (sending is currently broken)
  • Parse and know what the segwit outputs and inputs are
  • Verify transactions, especially those with segwit
  • Fix the problem where transactions are not being received

achow101 added 7 commits Mar 27, 2016
Added everything required to function on the Bitcoin Core segregated witness test network
Add recognization of the new input and output types used by segwit
Adds negotiation of witness usage through NODE_WITNESS service bit
Added transaction witness serialization stuff to PyTx. Still not complete.
Block file parsing with witnesses is completely fixed.
@goatpig goatpig merged commit b44edf1 into goatpig:SegWit Mar 30, 2016
goatpig pushed a commit that referenced this pull request Nov 10, 2017
af2da22 Add new tests for invalid Bech32 strings (Clark Moody)

Pull request description:

  Similar updates in the vein of #27, #29, #30, #31, #32

  Adds invalid Bech32 string test cases.

  Please note: Rust strings are UTF-8, so that the character literal `0xff` [turns into]( `0xc3bf` when accessed with the `bytes` function.

Tree-SHA512: 73f85762fc22059acb9c4b382068997fb0341354f1de26ecb2d75ba3c57aee80609fd2839967541c9a9f96ccdc04137140174396f5acfe62a6511fd9f18e703e
goatpig pushed a commit that referenced this pull request Nov 10, 2017
a4e672d Update Haskell tests (Pieter Wuille)

Pull request description:

Tree-SHA512: 7da982c437be4f424a431a758a478c1c59f12a8369fe44e9fe8759bc227b2090b0a63ddead7c819813b231a26da1be794d68fc3f2dcc8a41d778e7a76de9e4a2
pavel-kokolemin pushed a commit to pavel-kokolemin/BitcoinArmory that referenced this pull request Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants