Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/SCIM: improve backchannel signalling #5657

Merged
merged 3 commits into from May 17, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 17, 2023

Details

closes #5654

show warning on SCIM provider view page when provider is not used as backchannel provider

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…provider

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
…el at all

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 17, 2023 13:25
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3195a75) 92.62% compared to head (3e128dc) 92.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5657      +/-   ##
==========================================
- Coverage   92.62%   92.62%   -0.00%     
==========================================
  Files         546      546              
  Lines       26188    26194       +6     
==========================================
+ Hits        24255    24260       +5     
- Misses       1933     1934       +1     
Flag Coverage Δ
e2e 52.05% <0.00%> (+0.01%) ⬆️
integration 26.39% <0.00%> (-<0.01%) ⬇️
unit 89.48% <100.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/providers/scim/api/providers.py 83.34% <ø> (ø)
authentik/providers/scim/tasks.py 84.73% <100.00%> (+0.70%) ⬆️
authentik/providers/scim/tests/test_membership.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-scim-improve-backchannel-signalling-1684332461-3e128dc
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-scim-improve-backchannel-signalling-1684332461-3e128dc-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-scim-improve-backchannel-signalling-1684332461-3e128dc

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-scim-improve-backchannel-signalling-1684332461-3e128dc-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 68a1bcf into main May 17, 2023
56 of 57 checks passed
@BeryJu BeryJu deleted the providers/scim/improve-backchannel-signalling branch May 17, 2023 14:19
kensternberg-authentik added a commit that referenced this pull request May 17, 2023
* main:
  web: bump API Client version (#5664)
  web: bump @lingui/core from 4.1.0 to 4.1.2 in /web (#5658)
  providers/radius: add warning message when radius provider is not used with outpost (#5656)
  providers/SCIM: improve backchannel signalling (#5657)
  sources/ldap: improve error message (#5653)
  web/admin: fix radius provider page (#5651)
  ci: bump helm/kind-action from 1.5.0 to 1.6.0 (#5646)
  core: bump github.com/sirupsen/logrus from 1.9.0 to 1.9.1 (#5648)
  core: bump goauthentik.io/api/v3 from 3.2023041.12 to 3.2023050.1 (#5647)
  providers/scim: default to None for fields instead of empty list (#5642)
  web/flows: fix authenticator_validate device select not sent to backend (#5638)
  web/flows: update flow background (#5639)
  lib: fix fallback_names migration not working when multiple objects n… (#5637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCIM provider automatic sync not triggering since 2023.5.0
1 participant