Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/admin: fix radius provider page #5651

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 17, 2023

Details

Actually fixes what #5450 was supposed to fix

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 17, 2023 08:35
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -45.92 ⚠️

Comparison is base (886d783) 92.47% compared to head (c073657) 46.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5651       +/-   ##
===========================================
- Coverage   92.47%   46.55%   -45.92%     
===========================================
  Files         546      546               
  Lines       26188    26188               
===========================================
- Hits        24215    12188    -12027     
- Misses       1973    14000    +12027     
Flag Coverage Δ
e2e 44.80% <ø> (-6.39%) ⬇️
integration 26.39% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 394 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 3195a75 into main May 17, 2023
@BeryJu BeryJu deleted the web/admin/fix-radius-view-page branch May 17, 2023 08:56
@cfoellmann
Copy link

I hope there will be a 2023.5.1 point release to fix this finally.
I am eager to test radius and replace our existing simple radius

kensternberg-authentik added a commit that referenced this pull request May 17, 2023
* main:
  web: bump API Client version (#5664)
  web: bump @lingui/core from 4.1.0 to 4.1.2 in /web (#5658)
  providers/radius: add warning message when radius provider is not used with outpost (#5656)
  providers/SCIM: improve backchannel signalling (#5657)
  sources/ldap: improve error message (#5653)
  web/admin: fix radius provider page (#5651)
  ci: bump helm/kind-action from 1.5.0 to 1.6.0 (#5646)
  core: bump github.com/sirupsen/logrus from 1.9.0 to 1.9.1 (#5648)
  core: bump goauthentik.io/api/v3 from 3.2023041.12 to 3.2023050.1 (#5647)
  providers/scim: default to None for fields instead of empty list (#5642)
  web/flows: fix authenticator_validate device select not sent to backend (#5638)
  web/flows: update flow background (#5639)
  lib: fix fallback_names migration not working when multiple objects n… (#5637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants