Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/flows: fix authenticator_validate device select not sent to backend #5638

Merged
merged 3 commits into from
May 16, 2023

Conversation

tograss
Copy link
Contributor

@tograss tograss commented May 16, 2023

Details

Resolves #5020
The old code version always returned without doing anything. I assume the intention was to ensure "value" is not undefined and is not false.

I tried the new version with sms and totp device. Having both active at the same time or only one. I did however not test a Yubikey /Webauthn.

Checklist

  • Local tests pass (ak test authentik/)

  • The code has been formatted (make lint-fix)
    If changes to the frontend have been made

  • The code has been formatted (make web)

  • The translation files have been updated (make i18n-extract) <- This creates a lot of changes not caused by my fix so I did not commit this .

@tograss tograss requested a review from a team as a code owner May 16, 2023 19:54
@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 3c7900e
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6463df86a6ea3c000831c5c2
😎 Deploy Preview https://deploy-preview-5638--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (5213211) 92.63% compared to head (3c7900e) 92.61%.

❗ Current head 3c7900e differs from pull request most recent head 8398876. Consider uploading reports for the commit 8398876 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5638      +/-   ##
==========================================
- Coverage   92.63%   92.61%   -0.02%     
==========================================
  Files         546      546              
  Lines       26184    26184              
==========================================
- Hits        24254    24248       -6     
- Misses       1930     1936       +6     
Flag Coverage Δ
e2e 52.00% <ø> (+0.10%) ⬆️
integration 26.39% <ø> (ø)
unit 89.50% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
Copy link
Member

BeryJu commented May 16, 2023

@tograss I think the error came from the fact that value was assigned to _selectedDeviceChallenge and then we compare value to _selectedDeviceChallenge and return if they are the same, which they always will be. I fixed that comparison and with that the correct request is sent to the backend when selecting a challenge

@BeryJu BeryJu changed the title web: Fix backend not notified which challenge was selected web/flows: fix authenticator_validate device select not sent to backend May 16, 2023
@BeryJu BeryJu merged commit daa3c91 into goauthentik:main May 16, 2023
54 checks passed
@tograss
Copy link
Contributor Author

tograss commented May 17, 2023

Ah now I see what is intended at this point.

kensternberg-authentik added a commit that referenced this pull request May 17, 2023
* main:
  web: bump API Client version (#5664)
  web: bump @lingui/core from 4.1.0 to 4.1.2 in /web (#5658)
  providers/radius: add warning message when radius provider is not used with outpost (#5656)
  providers/SCIM: improve backchannel signalling (#5657)
  sources/ldap: improve error message (#5653)
  web/admin: fix radius provider page (#5651)
  ci: bump helm/kind-action from 1.5.0 to 1.6.0 (#5646)
  core: bump github.com/sirupsen/logrus from 1.9.0 to 1.9.1 (#5648)
  core: bump goauthentik.io/api/v3 from 3.2023041.12 to 3.2023050.1 (#5647)
  providers/scim: default to None for fields instead of empty list (#5642)
  web/flows: fix authenticator_validate device select not sent to backend (#5638)
  web/flows: update flow background (#5639)
  lib: fix fallback_names migration not working when multiple objects n… (#5637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFA SMS setup works but verification doesnt call SMS api
2 participants