-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web/flows: fix authenticator_validate device select not sent to backend #5638
Conversation
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5638 +/- ##
==========================================
- Coverage 92.63% 92.61% -0.02%
==========================================
Files 546 546
Lines 26184 26184
==========================================
- Hits 24254 24248 -6
- Misses 1930 1936 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@tograss I think the error came from the fact that |
Ah now I see what is intended at this point. |
* main: web: bump API Client version (#5664) web: bump @lingui/core from 4.1.0 to 4.1.2 in /web (#5658) providers/radius: add warning message when radius provider is not used with outpost (#5656) providers/SCIM: improve backchannel signalling (#5657) sources/ldap: improve error message (#5653) web/admin: fix radius provider page (#5651) ci: bump helm/kind-action from 1.5.0 to 1.6.0 (#5646) core: bump github.com/sirupsen/logrus from 1.9.0 to 1.9.1 (#5648) core: bump goauthentik.io/api/v3 from 3.2023041.12 to 3.2023050.1 (#5647) providers/scim: default to None for fields instead of empty list (#5642) web/flows: fix authenticator_validate device select not sent to backend (#5638) web/flows: update flow background (#5639) lib: fix fallback_names migration not working when multiple objects n… (#5637)
Details
Resolves #5020
The old code version always returned without doing anything. I assume the intention was to ensure "value" is not undefined and is not false.
I tried the new version with sms and totp device. Having both active at the same time or only one. I did however not test a Yubikey /Webauthn.
Checklist
Local tests pass (
ak test authentik/
)The code has been formatted (
make lint-fix
)If changes to the frontend have been made
The code has been formatted (
make web
)The translation files have been updated (
make i18n-extract
) <- This creates a lot of changes not caused by my fix so I did not commit this .