New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web/flows: fix RedirectStage not detecting absolute URLs correctly #5781
Conversation
…5732) Signed-off-by: Saeverix <1863379+Saeverix@users.noreply.github.com>
After I built my own Authentik image with the changes that @Saeverix made, I can confirm that all my OAuth connections are working properly. I am using:
Everything is working perfectly! |
@Smallinger thanks for checking my changes and confirming that it works. |
I've simplified the code a bit to use the native JS URL APIs and tested it with Portainer locally |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5781 +/- ##
===========================================
- Coverage 92.63% 26.42% -66.21%
===========================================
Files 547 547
Lines 26250 26250
===========================================
- Hits 24314 6933 -17381
- Misses 1936 19317 +17381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@BeryJu that's also a nice change to prevent the |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
* main: (58 commits) web: bump @babel/preset-env from 7.22.2 to 7.22.4 in /web (#5808) web: bump @typescript-eslint/eslint-plugin from 5.59.7 to 5.59.8 in /web (#5805) web: bump @babel/plugin-transform-runtime from 7.22.2 to 7.22.4 in /web (#5806) web: bump @typescript-eslint/parser from 5.59.7 to 5.59.8 in /web (#5807) stages/deny: fix typos (#5800) core: bump coverage from 7.2.6 to 7.2.7 (#5809) blueprints: allow setting user's passwords from blueprints (#5797) providers/proxy: add support for traefik.io API and CRD (#5801) web: fix build (#5798) web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781) lifecycle: Add depends_on for worker and server container (#5634) web: bump @babel/preset-env from 7.21.5 to 7.22.2 in /web (#5791) web: bump @babel/plugin-proposal-decorators from 7.21.0 to 7.22.3 in /web (#5787) web: bump @lingui/core from 4.1.2 to 4.2.0 in /web (#5782) website: bump postcss from 8.4.23 to 8.4.24 in /website (#5783) web: bump @babel/plugin-transform-runtime from 7.21.4 to 7.22.2 in /web (#5789) core: bump goauthentik.io/api/v3 from 3.2023051.3 to 3.2023052.1 (#5788) web: bump @babel/core from 7.21.8 to 7.22.1 in /web (#5790) web: bump yaml from 2.3.0 to 2.3.1 in /web (#5792) core: bump django-otp from 1.2.0 to 1.2.1 (#5794) ...
…5781) * web: getURL() method in RedirectStage.ts now actually detects URLs (#5732) Signed-off-by: Saeverix <1863379+Saeverix@users.noreply.github.com> * use native API to build full URL Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Saeverix <1863379+Saeverix@users.noreply.github.com> Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens Langhammer <jens@goauthentik.io>
* main: web: bump API Client version (#5826) release: 2023.5.3 website/docs: prepare 2023.5.3 (#5824) ci: build outpost binaries statically linked (#5823) blueprints: fix API validation with OCI blueprint path (#5822) ci: replace github bot account with github app (#5819) providers/ldap: fix LDAP Outpost application selection (#5812) stages/deny: fix typos (#5800) web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
* main: web: bump API Client version (#5826) release: 2023.5.3 website/docs: prepare 2023.5.3 (#5824) ci: build outpost binaries statically linked (#5823) blueprints: fix API validation with OCI blueprint path (#5822) ci: replace github bot account with github app (#5819) providers/ldap: fix LDAP Outpost application selection (#5812) stages/deny: fix typos (#5800) web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
Details
Resolves Portianer OAuth is broken after update. #5732
Changes
New Features
getURL()
method inRedirectStage.ts
now actually detects URLsChecklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)make i18n-extract
)If applicable
make website
)