Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/ldap: fix LDAP Outpost application selection #5812

Merged
merged 1 commit into from May 31, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 30, 2023

Details

closes #5810

Changes

New Features

Currently the API only filters for directly assigned applications, not backchannel applications

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 30, 2023 11:15
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 88.89% and project coverage change: +2.54 🎉

Comparison is base (8daa8e1) 90.04% compared to head (b197691) 92.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5812      +/-   ##
==========================================
+ Coverage   90.04%   92.58%   +2.54%     
==========================================
  Files         549      549              
  Lines       26305    26320      +15     
==========================================
+ Hits        23685    24367     +682     
+ Misses       2620     1953     -667     
Flag Coverage Δ
e2e 51.84% <88.89%> (+5.08%) ⬆️
integration 26.48% <27.78%> (?)
unit 89.44% <88.89%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/core/api/providers.py 95.92% <83.34%> (-1.85%) ⬇️
authentik/providers/ldap/api.py 95.56% <91.67%> (+4.38%) ⬆️

... and 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-ldap-fix-outpost-selection-1685446084-b197691
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-ldap-fix-outpost-selection-1685446084-b197691-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-ldap-fix-outpost-selection-1685446084-b197691

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-ldap-fix-outpost-selection-1685446084-b197691-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit fd4c5f5 into main May 31, 2023
56 of 57 checks passed
@BeryJu BeryJu deleted the providers/ldap/fix-outpost-selection branch May 31, 2023 12:14
BeryJu added a commit that referenced this pull request May 31, 2023
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request May 31, 2023
* main:
  ci: build outpost binaries statically linked (#5823)
  blueprints: fix API validation with OCI blueprint path (#5822)
  ci: replace github bot account with github app (#5819)
  providers/ldap: fix LDAP Outpost application selection (#5812)
  website: handle go-get requests statically (#5821)
  web: bump @rollup/plugin-node-resolve from 15.0.2 to 15.1.0 in /web (#5816)
  core: bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (#5818)
  web: bump pyright from 1.1.310 to 1.1.311 in /web (#5817)
  website: switch to selfhosted plausible
kensternberg-authentik added a commit that referenced this pull request Jun 1, 2023
* main:
  web: bump API Client version (#5826)
  release: 2023.5.3
  website/docs: prepare 2023.5.3 (#5824)
  ci: build outpost binaries statically linked (#5823)
  blueprints: fix API validation with OCI blueprint path (#5822)
  ci: replace github bot account with github app (#5819)
  providers/ldap: fix LDAP Outpost application selection (#5812)
  stages/deny: fix typos (#5800)
  web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
kensternberg-authentik added a commit that referenced this pull request Jun 5, 2023
* main:
  ci: build outpost binaries statically linked (#5823)
  blueprints: fix API validation with OCI blueprint path (#5822)
  ci: replace github bot account with github app (#5819)
  providers/ldap: fix LDAP Outpost application selection (#5812)
  website: handle go-get requests statically (#5821)
  web: bump @rollup/plugin-node-resolve from 15.0.2 to 15.1.0 in /web (#5816)
  core: bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (#5818)
  web: bump pyright from 1.1.310 to 1.1.311 in /web (#5817)
  website: switch to selfhosted plausible
kensternberg-authentik added a commit that referenced this pull request Jun 5, 2023
* main:
  web: bump API Client version (#5826)
  release: 2023.5.3
  website/docs: prepare 2023.5.3 (#5824)
  ci: build outpost binaries statically linked (#5823)
  blueprints: fix API validation with OCI blueprint path (#5822)
  ci: replace github bot account with github app (#5819)
  providers/ldap: fix LDAP Outpost application selection (#5812)
  stages/deny: fix typos (#5800)
  web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backchannel LDAP providers missing from outpost configuration page
1 participant