Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/deny: fix typos #5800

Merged
merged 2 commits into from May 30, 2023
Merged

stages/deny: fix typos #5800

merged 2 commits into from May 30, 2023

Conversation

rlew-is
Copy link
Contributor

@rlew-is rlew-is commented May 29, 2023

Details

There were a couple of minor typos in the deny stage files.

Changes

Fixed typos in the Deny stage files

New Features

N/A

Breaking Changes

None

Fix typo in "Cancells the current flow"

Signed-off-by: rlew-is <96594816+rlew-is@users.noreply.github.com>
Fix typo in "Cancells the current flow"

Signed-off-by: rlew-is <96594816+rlew-is@users.noreply.github.com>
@rlew-is rlew-is requested a review from a team as a code owner May 29, 2023 14:40
@BeryJu BeryJu changed the title Fixed some minor typos stages/deny: fix typos May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (81c22fa) 92.63% compared to head (250bf83) 92.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5800      +/-   ##
==========================================
+ Coverage   92.63%   92.64%   +0.01%     
==========================================
  Files         547      547              
  Lines       26250    26250              
==========================================
+ Hits        24315    24316       +1     
+ Misses       1935     1934       -1     
Flag Coverage Δ
e2e 51.91% <ø> (-<0.01%) ⬇️
integration 26.42% <ø> (ø)
unit 89.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/stages/deny/models.py 100.00% <ø> (ø)
authentik/stages/deny/stage.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 0b25c61 into goauthentik:main May 30, 2023
57 checks passed
kensternberg-authentik added a commit that referenced this pull request May 30, 2023
* main: (58 commits)
  web: bump @babel/preset-env from 7.22.2 to 7.22.4 in /web (#5808)
  web: bump @typescript-eslint/eslint-plugin from 5.59.7 to 5.59.8 in /web (#5805)
  web: bump @babel/plugin-transform-runtime from 7.22.2 to 7.22.4 in /web (#5806)
  web: bump @typescript-eslint/parser from 5.59.7 to 5.59.8 in /web (#5807)
  stages/deny: fix typos (#5800)
  core: bump coverage from 7.2.6 to 7.2.7 (#5809)
  blueprints: allow setting user's passwords from blueprints (#5797)
  providers/proxy: add support for traefik.io API and CRD (#5801)
  web: fix build (#5798)
  web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
  lifecycle: Add depends_on for worker and server container (#5634)
  web: bump @babel/preset-env from 7.21.5 to 7.22.2 in /web (#5791)
  web: bump @babel/plugin-proposal-decorators from 7.21.0 to 7.22.3 in /web (#5787)
  web: bump @lingui/core from 4.1.2 to 4.2.0 in /web (#5782)
  website: bump postcss from 8.4.23 to 8.4.24 in /website (#5783)
  web: bump @babel/plugin-transform-runtime from 7.21.4 to 7.22.2 in /web (#5789)
  core: bump goauthentik.io/api/v3 from 3.2023051.3 to 3.2023052.1 (#5788)
  web: bump @babel/core from 7.21.8 to 7.22.1 in /web (#5790)
  web: bump yaml from 2.3.0 to 2.3.1 in /web (#5792)
  core: bump django-otp from 1.2.0 to 1.2.1 (#5794)
  ...
BeryJu pushed a commit that referenced this pull request May 31, 2023
* Fix typo in stage.py

Fix typo in "Cancells the current flow"

Signed-off-by: rlew-is <96594816+rlew-is@users.noreply.github.com>

* Fix typo in models.py

Fix typo in "Cancells the current flow"

Signed-off-by: rlew-is <96594816+rlew-is@users.noreply.github.com>

---------

Signed-off-by: rlew-is <96594816+rlew-is@users.noreply.github.com>
kensternberg-authentik added a commit that referenced this pull request Jun 1, 2023
* main:
  web: bump API Client version (#5826)
  release: 2023.5.3
  website/docs: prepare 2023.5.3 (#5824)
  ci: build outpost binaries statically linked (#5823)
  blueprints: fix API validation with OCI blueprint path (#5822)
  ci: replace github bot account with github app (#5819)
  providers/ldap: fix LDAP Outpost application selection (#5812)
  stages/deny: fix typos (#5800)
  web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
kensternberg-authentik added a commit that referenced this pull request Jun 5, 2023
* main:
  web: bump API Client version (#5826)
  release: 2023.5.3
  website/docs: prepare 2023.5.3 (#5824)
  ci: build outpost binaries statically linked (#5823)
  blueprints: fix API validation with OCI blueprint path (#5822)
  ci: replace github bot account with github app (#5819)
  providers/ldap: fix LDAP Outpost application selection (#5812)
  stages/deny: fix typos (#5800)
  web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants