Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: grafana: add Helm and Terraform config examples #7121

Merged
merged 2 commits into from Oct 19, 2023

Conversation

senare
Copy link
Contributor

@senare senare commented Oct 9, 2023

Details

Ill try and add some example for doing this using terraform, will that be oki ?

Also added helm section


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@senare senare requested a review from a team as a code owner October 9, 2023 19:06
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 5112bee
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65311d066289a20008d22545
😎 Deploy Preview https://deploy-preview-7121--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 5112bee
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65311d067abbad00089e191c
😎 Deploy Preview https://deploy-preview-7121--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 4 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

website/integrations/services/grafana/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/grafana/index.mdx Outdated Show resolved Hide resolved
@senare
Copy link
Contributor Author

senare commented Oct 11, 2023

I don't think we need to spec 'authentik Self-signed Certificate' it would be default as in the other cases ...

I will update and retest my configuration and update after !

@rissson
Copy link
Member

rissson commented Oct 11, 2023

I don't think we need to spec 'authentik Self-signed Certificate' it would be default as in the other cases ...

You may be right. However, it might be the default on the UI but not in the terraform provider.

@senare
Copy link
Contributor Author

senare commented Oct 13, 2023

Sorry, i don't want to leave this hanging!

  • I updated with a disclaimer would that be good enough for now ?
  • Also added groups (Grafana Admins, Grafana Editors, Grafana Editors) as assumed.
  • Removed the cert seams to be fine with default (when I test anyways).
  • However i added client_id back in again as terraform provider has it as required.
  • Rebase & Squash

Goode enough ?

Copy link
Member

@rissson rissson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rewording but otherwise LGTM

website/integrations/services/grafana/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/grafana/index.mdx Outdated Show resolved Hide resolved
@senare senare force-pushed the main branch 2 times, most recently from 6d3e022 to ccff235 Compare October 16, 2023 14:17
@rissson rissson changed the title Added helm ref and Terraform Provider config website/integrations: grafana: add Helm and Terraform config examples Oct 16, 2023
@rissson rissson requested a review from tanberry October 16, 2023 15:17
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (63a9cf2) 92.63% compared to head (5112bee) 92.63%.
Report is 49 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7121    +/-   ##
========================================
  Coverage   92.63%   92.63%            
========================================
  Files         568      584    +16     
  Lines       28049    28707   +658     
========================================
+ Hits        25983    26593   +610     
- Misses       2066     2114    +48     
Flag Coverage Δ
e2e 51.16% <ø> (+0.01%) ⬆️
integration 26.12% <ø> (-0.21%) ⬇️
unit 89.62% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 58 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @senare !

website/integrations/services/grafana/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/grafana/index.mdx Outdated Show resolved Hide resolved
   Added disclaimer about secret's in Helm or i.e values.yaml

Co-authored-by: risson <18313093+rissson@users.noreply.github.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: senare <senare@gmail.com>
@senare
Copy link
Contributor Author

senare commented Oct 19, 2023

I did run

$ make website-lint-fix

but it wont say what's not linted nor did it correct it, any advice ?

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu enabled auto-merge (squash) October 19, 2023 12:12
@BeryJu BeryJu merged commit 34367a7 into goauthentik:main Oct 19, 2023
61 of 63 checks passed
kensternberg-authentik added a commit that referenced this pull request Oct 19, 2023
* main: (57 commits)
  stages/email: Fix query parameters getting lost in Email links (#5376)
  core/rbac: fix missing field when removing perm, add delete from object page (#7226)
  website/integrations: grafana: add Helm and Terraform config examples (#7121)
  web: bump @types/codemirror from 5.60.11 to 5.60.12 in /web (#7223)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7224)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7225)
  website/blogs: blog about sso tax (#7202)
  web: Application wizard v2 with tests (#7004)
  web: bump API Client version (#7220)
  core: bump goauthentik.io/api/v3 from 3.2023083.7 to 3.2023083.8 (#7221)
  providers/radius: TOTP MFA support (#7217)
  web: bump API Client version (#7218)
  stage/deny: add custom message (#7144)
  docs: update full-dev-setup docs (#7205)
  enterprise: bump license usage task frequency (#7215)
  web: bump the storybook group in /web with 5 updates (#7212)
  web: bump the sentry group in /web with 2 updates (#7211)
  Revert "web: Updates to the Context and Tasks libraries from lit. (#7168)"
  web: bump @types/codemirror from 5.60.10 to 5.60.11 in /web (#7209)
  web: bump @types/chart.js from 2.9.38 to 2.9.39 in /web (#7206)
  ...
kensternberg-authentik added a commit that referenced this pull request Oct 19, 2023
* main: (119 commits)
  stages/email: Fix query parameters getting lost in Email links (#5376)
  core/rbac: fix missing field when removing perm, add delete from object page (#7226)
  website/integrations: grafana: add Helm and Terraform config examples (#7121)
  web: bump @types/codemirror from 5.60.11 to 5.60.12 in /web (#7223)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7224)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7225)
  website/blogs: blog about sso tax (#7202)
  web: Application wizard v2 with tests (#7004)
  web: bump API Client version (#7220)
  core: bump goauthentik.io/api/v3 from 3.2023083.7 to 3.2023083.8 (#7221)
  providers/radius: TOTP MFA support (#7217)
  web: bump API Client version (#7218)
  stage/deny: add custom message (#7144)
  docs: update full-dev-setup docs (#7205)
  enterprise: bump license usage task frequency (#7215)
  web: bump the storybook group in /web with 5 updates (#7212)
  web: bump the sentry group in /web with 2 updates (#7211)
  Revert "web: Updates to the Context and Tasks libraries from lit. (#7168)"
  web: bump @types/codemirror from 5.60.10 to 5.60.11 in /web (#7209)
  web: bump @types/chart.js from 2.9.38 to 2.9.39 in /web (#7206)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants