Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix task clean_expiring_models removing valid sessions with using database storage #9598

Merged
merged 1 commit into from
May 6, 2024

Conversation

rissson
Copy link
Member

@rissson rissson commented May 6, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this May 6, 2024
@rissson rissson requested a review from a team as a code owner May 6, 2024 11:42
Copy link

netlify bot commented May 6, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit e78e7ae
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6638c2d92dae63000829b859

Copy link

netlify bot commented May 6, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit e78e7ae
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6638c2d93882e8000802617c

@rissson
Copy link
Member Author

rissson commented May 6, 2024

/cherry-pick version-2024.4

authentik/core/tasks.py Outdated Show resolved Hide resolved
…ng database storage

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 92.48%. Comparing base (74da359) to head (e78e7ae).

Files Patch % Lines
authentik/core/tasks.py 50.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9598      +/-   ##
==========================================
- Coverage   92.51%   92.48%   -0.03%     
==========================================
  Files         669      669              
  Lines       32878    32889      +11     
==========================================
+ Hits        30416    30419       +3     
- Misses       2462     2470       +8     
Flag Coverage Δ
e2e 50.47% <15.00%> (-0.02%) ⬇️
integration 25.92% <15.00%> (+<0.01%) ⬆️
unit 89.80% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson enabled auto-merge (squash) May 6, 2024 11:48
@rissson rissson merged commit 244cbc5 into main May 6, 2024
68 of 69 checks passed
@rissson rissson deleted the fix-session-disappearing branch May 6, 2024 12:02
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 6, 2024
BeryJu pushed a commit that referenced this pull request May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e78e7ae3f184b9b1b8ee64ab9d8e95f2836e0a4a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e78e7ae3f184b9b1b8ee64ab9d8e95f2836e0a4a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e78e7ae3f184b9b1b8ee64ab9d8e95f2836e0a4a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e78e7ae3f184b9b1b8ee64ab9d8e95f2836e0a4a-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants