Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix condition in task clean_expiring_models #9603

Merged
merged 1 commit into from
May 6, 2024

Conversation

rissson
Copy link
Member

@rissson rissson commented May 6, 2024

Details

Follow-up for #9598 


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson requested a review from a team as a code owner May 6, 2024 12:11
@rissson rissson self-assigned this May 6, 2024
@rissson rissson enabled auto-merge (squash) May 6, 2024 12:11
Copy link

netlify bot commented May 6, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 6b10eac
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6638c8f77beb820008f32ff7

@rissson
Copy link
Member Author

rissson commented May 6, 2024

/cherry-pick version-2024.4

Copy link

netlify bot commented May 6, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 6b10eac
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6638c8f785886b0008163ba9

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.49%. Comparing base (244cbc5) to head (6b10eac).
Report is 2 commits behind head on main.

Files Patch % Lines
authentik/core/tasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9603   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files         669      669           
  Lines       32889    32889           
=======================================
  Hits        30421    30421           
  Misses       2468     2468           
Flag Coverage Δ
e2e 50.48% <0.00%> (ø)
integration 25.92% <0.00%> (ø)
unit 89.80% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson merged commit 801a28e into main May 6, 2024
68 of 69 checks passed
@rissson rissson deleted the fix-session-disappearing branch May 6, 2024 12:29
BeryJu pushed a commit that referenced this pull request May 6, 2024
…#9604)

core: fix condition in task clean_expiring_models (#9603)

Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link
Contributor

github-actions bot commented May 6, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-6b10eac18f4acdc5fa5bcc6e038108209ce69d4a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-6b10eac18f4acdc5fa5bcc6e038108209ce69d4a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-6b10eac18f4acdc5fa5bcc6e038108209ce69d4a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-6b10eac18f4acdc5fa5bcc6e038108209ce69d4a-arm64

Afterwards, run the upgrade commands from the latest release notes.

kensternberg-authentik added a commit that referenced this pull request May 8, 2024
* main: (42 commits)
  website/docs: prepare 2024.4.2 release notes (#9555)
  web: bump the esbuild group in /web with 2 updates (#9616)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9611)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9560)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9563)
  ci: bump golangci/golangci-lint-action from 5 to 6 (#9615)
  web: bump esbuild from 0.20.2 to 0.21.0 in /web (#9617)
  core: bump cryptography from 42.0.6 to 42.0.7 (#9618)
  core: bump sentry-sdk from 2.0.1 to 2.1.1 (#9619)
  core: bump django from 5.0.4 to 5.0.5 (#9620)
  core, web: update translations (#9613)
  website/docs: move Sources from Integrations into Docs (#9515)
  website/docs: add procedurals to flow inspector docs (#9556)
  core: bump jinja2 from 3.1.3 to 3.1.4 (#9610)
  web: clean up the options rendering in PromptForm (#9564)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9608)
  website/docs: add instructions for deploying radius manually with docker compose (#9605)
  sources/scim: fix duplicate groups and invalid schema (#9466)
  core: fix condition in task clean_expiring_models (#9603)
  translate: Updates for file web/xliff/en.xlf in fr (#9600)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants