authentik: ci: add extraContainers testing #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rissson
changed the title
rissson
reviewed
Mar 1, 2024
| @@ -0,0 +1,8 @@ | |||
| worker: | |||
There was a problem hiding this comment.
Pretty sure you need the boilerplate that is in ct-values.yaml for this to work.
There was a problem hiding this comment.
This is no boilerplait, that is a "chart-testing lint (unit)test"
it is not needed, but if you want to pretend such bug it is helpfull
>>> helm lint charts/authentik --values charts/authentik/ci/ct-extracontainer-values.yaml
==> Linting charts/authentik
Error: templates/server/deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 93: did not find expected key
There was a problem hiding this comment.
I meant that you need some basic values apart from what you are testing for it to work, like what is ct-values.yaml and in all other tests we currently have.
|
#250 already merged |
|
miss that - i have split that MR |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
rissson
approved these changes
Mar 15, 2024
szinn
pushed a commit
to szinn/k8s-homelab
that referenced
this pull request
Apr 17, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [authentik](https://goauthentik.io) ([source](https://togithub.com/goauthentik/helm)) | patch | `2024.2.2` -> `2024.2.3` | --- ### Release Notes <details> <summary>goauthentik/helm (authentik)</summary> ### [`v2024.2.3`](https://togithub.com/goauthentik/helm/releases/tag/authentik-2024.2.3) [Compare Source](https://togithub.com/goauthentik/helm/compare/authentik-2024.2.2...authentik-2024.2.3) authentik is an open-source Identity Provider focused on flexibility and versatility #### What's Changed - authentik: ci: rename values files to run with chart-testing correctly by [@​wrenix](https://togithub.com/wrenix) in [goauthentik/helm#249 - authentik: ci: add extraContainers testing by [@​wrenix](https://togithub.com/wrenix) in [goauthentik/helm#248 - authentik: worker deployment: fix volume type for secret blueprints by [@​sherif-fanous](https://togithub.com/sherif-fanous) in [goauthentik/helm#257 - bump to 2024.2.3 by [@​BeryJu](https://togithub.com/BeryJu) in [goauthentik/helm#259 #### New Contributors - [@​sherif-fanous](https://togithub.com/sherif-fanous) made their first contribution in [goauthentik/helm#257 **Full Changelog**: goauthentik/helm@authentik-2024.2.2...authentik-2024.2.3 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMwMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test to show bug #247
created by @rissson on #230