Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentik: ci: rename values files to run with chart-testing correctly #249

Merged
merged 3 commits into from Mar 15, 2024

Conversation

wrenix
Copy link
Contributor

@wrenix wrenix commented Feb 29, 2024

current the chart-testing does not run with the value-files ...

https://github.com/helm/chart-testing/blob/main/doc/ct_lint.md

Charts may have multiple custom values files matching the glob pattern '*-values.yaml' in a directory named 'ci' in the root of the chart's directory. The chart is linted for each of these files. If no custom values file is present, the chart is linted with defaults.

'*-values.yaml'

@wrenix wrenix requested a review from a team as a code owner February 29, 2024 19:11
@rissson rissson changed the title fix(authentik): rename values files to run with chart-testing correct authentik: ci: rename values files to run with chart-testing correctly Mar 1, 2024
@rissson rissson enabled auto-merge (squash) March 1, 2024 10:37
auto-merge was automatically disabled March 12, 2024 21:49

Head branch was pushed to by a user without write access

@wrenix wrenix force-pushed the fix/ct-values-name branch 2 times, most recently from 820c940 to a148b59 Compare March 12, 2024 21:50
Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to bump the version for this change

Aside from that it would be nice to have a better way to see failures, but I assume there's no way to integrate this with a GitHub Actions Matrix

@wrenix
Copy link
Contributor Author

wrenix commented Mar 12, 2024

Why need an Github action matrix, if the ct lint does that job?

Linting chart with values file "charts/authentik/ci/ct-blueprints-values.yaml"...

>>> helm lint charts/authentik --values charts/authentik/ci/ct-blueprints-values.yaml
==> Linting charts/authentik

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/authentik/ci/ct-geoip-values.yaml"...

>>> helm lint charts/authentik --values charts/authentik/ci/ct-geoip-values.yaml
==> Linting charts/authentik

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/authentik/ci/ct-hpa-values.yaml"...

>>> helm lint charts/authentik --values charts/authentik/ci/ct-hpa-values.yaml
==> Linting charts/authentik

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/authentik/ci/ct-pdb-max-values.yaml"...

>>> helm lint charts/authentik --values charts/authentik/ci/ct-pdb-max-values.yaml
==> Linting charts/authentik

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/authentik/ci/ct-pdb-min-values.yaml"...

>>> helm lint charts/authentik --values charts/authentik/ci/ct-pdb-min-values.yaml
==> Linting charts/authentik

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/authentik/ci/ct-values.yaml"...

>>> helm lint charts/authentik --values charts/authentik/ci/ct-values.yaml
==> Linting charts/authentik

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ authentik => (version: "2024.2.3", path: "charts/authentik")

@wrenix
Copy link
Contributor Author

wrenix commented Mar 13, 2024

remove Chart.yaml - version again

@rissson
Copy link
Member

rissson commented Mar 13, 2024

Let's fix the CI before merging though

@wrenix
Copy link
Contributor Author

wrenix commented Mar 13, 2024

Sorry, not my buisness - i just wanted to show, that you use the values-files / linter incorrect.


For example, you has the problem:
In your chart-testing installation (see value files) you use e.g. geoip without set an example token and so on.
So the pods failed to startup ....

@rissson
Copy link
Member

rissson commented Mar 14, 2024

Yeah it was just a general comment not directed at you. I'll take some time and fix the tests before merging.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson merged commit 78a269f into goauthentik:main Mar 15, 2024
2 checks passed
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Apr 17, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [authentik](https://goauthentik.io)
([source](https://togithub.com/goauthentik/helm)) | patch | `2024.2.2`
-> `2024.2.3` |

---

### Release Notes

<details>
<summary>goauthentik/helm (authentik)</summary>

###
[`v2024.2.3`](https://togithub.com/goauthentik/helm/releases/tag/authentik-2024.2.3)

[Compare
Source](https://togithub.com/goauthentik/helm/compare/authentik-2024.2.2...authentik-2024.2.3)

authentik is an open-source Identity Provider focused on flexibility and
versatility

#### What's Changed

- authentik: ci: rename values files to run with chart-testing correctly
by [@&#8203;wrenix](https://togithub.com/wrenix) in
[goauthentik/helm#249
- authentik: ci: add extraContainers testing by
[@&#8203;wrenix](https://togithub.com/wrenix) in
[goauthentik/helm#248
- authentik: worker deployment: fix volume type for secret blueprints by
[@&#8203;sherif-fanous](https://togithub.com/sherif-fanous) in
[goauthentik/helm#257
- bump to 2024.2.3 by [@&#8203;BeryJu](https://togithub.com/BeryJu) in
[goauthentik/helm#259

#### New Contributors

- [@&#8203;sherif-fanous](https://togithub.com/sherif-fanous) made their
first contribution in
[goauthentik/helm#257

**Full Changelog**:
goauthentik/helm@authentik-2024.2.2...authentik-2024.2.3

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMwMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants