Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Runner flags in Compile #5

Merged
merged 1 commit into from
Aug 5, 2016
Merged

Conversation

AitorATuin
Copy link
Contributor

Let Runner use the new flags and show some messages about what's going on.

See this: gobolinux/Scripts#5

@lucasvr
Copy link
Member

lucasvr commented Aug 5, 2016

Aitor, I wonder what's the benefit of re-spawning with Runner if we know that the sandbox cannot be created?

@AitorATuin
Copy link
Contributor Author

AitorATuin commented Aug 5, 2016

None, but it's how it was working before (https://github.com/gobolinux/Compile/blob/master/bin/Compile#L298) :)
I agree that it's a non-sense so I will remove it (I really wanted to do it from the beginning)

@hishamhm
Copy link
Member

hishamhm commented Aug 5, 2016

I do prefer the fallback behavior in Runner, so that Runner foo always runs (with or without the overlay). It does print a warning anyway, so I think it will produce less friction when using Runner from the command line. Keeping it as it was produces the same end result (a warning message and the program running without the overlay), only with less code and forks.

@AitorATuin
Copy link
Contributor Author

AitorATuin commented Aug 5, 2016

I don't see the point. I agree that enabling a default fallback has less friction for the user but i feel it very counterintuitive. The main purpose of Runner is run a program inside a sandbox so I'm expecting (as a unix user) from it to do nothing if the sandbox is not available and to give it a flag if I want to force the execution of the program.
This also has the benefit of a better interface to script against it, more control on how the program is working.
@lucasvr what do you think?

@hishamhm
Copy link
Member

hishamhm commented Aug 5, 2016

@AitorATuin Fair points, I'm convinced. The behavior of Compile, which is the higher-level interface, will be frictionless (for both main scenarios: on 016 systems people will have 4.0+ anyway, and in Rootless they won't have suid Runner). When using Runner directly, people will want more control.

@hishamhm hishamhm merged commit b923ee6 into gobolinux:master Aug 5, 2016
@hishamhm
Copy link
Member

hishamhm commented Aug 5, 2016

(I'll just lower the log level of the messages a bit)

@AitorATuin AitorATuin deleted the runner branch August 24, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants