Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organizes routes a bit and avoids overriding index.html #64

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Organizes routes a bit and avoids overriding index.html #64

merged 3 commits into from
Dec 19, 2019

Conversation

paganotoni
Copy link
Member

This is related with #47.

@paganotoni paganotoni requested a review from a team December 19, 2019 15:53
mclark4386
mclark4386 approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@mclark4386 mclark4386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@paganotoni paganotoni merged commit 2a8c9d8 into master Dec 19, 2019
@paganotoni paganotoni deleted the task-signin branch December 19, 2019 23:59
@AtomicNibble
Copy link

This breaks the tests as some of the tests are still checking for /signin etc.

@paganotoni
Copy link
Member Author

Taking a look. Thanks for the heads up @AtomicNibble

@paganotoni
Copy link
Member Author

@AtomicNibble fixed this one in #65, thanks for the heads up.

@AtomicNibble
Copy link

Thanks.

@paganotoni paganotoni mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mclark4386 mclark4386 mclark4386 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paganotoni @AtomicNibble @mclark4386