Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templates to support current buffalo generated code (v0.16.20) #81

Closed
wants to merge 1 commit into from

Conversation

pijalu
Copy link

@pijalu pijalu commented Feb 19, 2021

Buffalo uses different version of pop and this results in exception during casting.
Updating them to current version solves issues and allow plugin usage

@pijalu
Copy link
Author

pijalu commented Feb 19, 2021

this also seems to solve part of #67 (the login form with POST /auth/new) - route is now as expected (/auth)

@mattboll
Copy link

Hello,
It looks like the pull request will work for buffalo v0.17.2 too

@sio4
Copy link
Member

sio4 commented May 14, 2022

Ah, I am sorry. We had some progress on the module dependency upgrading across all packages along with packr removal last winter and changes on this PR were also a part of that progress. I didn't realize there was a related PR (this) during the period.

Closing this PR as it is obsoleted now. However, many thanks for filing a PR!

@sio4 sio4 closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants