Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Better handle errors display as JSON or XML #1351

Merged
merged 3 commits into from
Oct 8, 2018

Conversation

stanislas-m
Copy link
Member

@stanislas-m stanislas-m commented Oct 4, 2018

  • Make sure using the XML mime type returns a XML-formatted error.
  • Use the same struct for XML & JSON.
  • Add a new attribute to have only the cause and not the full trace.

@stanislas-m stanislas-m requested a review from a team October 4, 2018 19:07
@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@1cd0d04). Click here to learn what that means.
The diff coverage is 73.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1351   +/-   ##
==============================================
  Coverage               ?   48.82%           
==============================================
  Files                  ?       92           
  Lines                  ?     4057           
  Branches               ?        0           
==============================================
  Hits                   ?     1981           
  Misses                 ?     1969           
  Partials               ?      107
Impacted Files Coverage Δ
errors.go 75% <73.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd0d04...ea1e2d5. Read the comment docs.

mclark4386
mclark4386 previously approved these changes Oct 5, 2018
@stanislas-m
Copy link
Member Author

Fixes #1353.

@markbates markbates added this to the v0.13.0 milestone Oct 8, 2018
@markbates markbates merged commit 0b3a5bf into development Oct 8, 2018
@markbates markbates deleted the task/better-non-html-errors branch October 8, 2018 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants