Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

updated router Group function to acount for Windows path cruft #259

Merged
merged 5 commits into from
Feb 21, 2017
Merged

updated router Group function to acount for Windows path cruft #259

merged 5 commits into from
Feb 21, 2017

Conversation

schigh
Copy link
Contributor

@schigh schigh commented Feb 21, 2017

Refer to:
#258

@markbates
Copy link
Member

@schigh it looks like the tests are failing.

@schigh
Copy link
Contributor Author

schigh commented Feb 21, 2017

Examining each failed test in Travis. All my local invocations of go test -race are succeeding

@markbates
Copy link
Member

Try running docker build . locally, that's what Travis runs.

@markbates markbates closed this Feb 21, 2017
@markbates markbates reopened this Feb 21, 2017
@schigh
Copy link
Contributor Author

schigh commented Feb 21, 2017

The final update was much simpler...

@markbates markbates merged commit a83310c into gobuffalo:master Feb 21, 2017
@markbates
Copy link
Member

lol. It's always that way. :)

Thanks!

@markbates markbates added the os-specific This issue is OS-specific label Mar 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
os-specific This issue is OS-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schigh @markbates