Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chocolatey Install Instructions #529

Merged
merged 5 commits into from
Dec 10, 2019
Merged

Added Chocolatey Install Instructions #529

merged 5 commits into from
Dec 10, 2019

Conversation

digitalcoyote
Copy link
Contributor

Buffalo now has a chocolatey package, so I updated the French and English Installation Instructions (Don't know any French, so I used the Scoop Instructions as a template)

Added Chocolatey Install Instructions
Added French Installation Instructions for Chocolatey
@digitalcoyote digitalcoyote requested a review from a team November 22, 2019 20:41
Copy link
Member

@kteb kteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be good to precise that Chocolatey doesn't have necessary the latest version. Actually it looks like it's version 0.14.11 where buffalo is at 0.15.3

@digitalcoyote
Copy link
Contributor Author

digitalcoyote commented Dec 3, 2019

Chocolatey actually has 0.15.1 in review (see version history for the package). Once that is approved, newer versions will be pushed up as well. You can add options to the install command to install unreviewed versions, but doing so is considered unsafe. I expect the package to become trusted eventually (a status for existing packages with reliable history) which will speed up review.

EDIT: I did find that the file naming for "386" and "amd64" releases changed to "i386" and "x86_64". This has caused it to skip 0.15.2.

@kteb
Copy link
Member

kteb commented Dec 5, 2019

Just a small disclosure letting people checks which version is the current version of buffalo and the current version of Chocolatey. Otherwise thanks a lot for the work (mainly on Chocolatey) but also by updating the docs.

Added disclosure to let people know that the version on Chocolatey may not be the latest available version.
@digitalcoyote
Copy link
Contributor Author

digitalcoyote commented Dec 5, 2019

I don't know French (I made the changes to french documentation via Copy-Pasta and a little help from Google Translate to verify it). Would it be better to leave it out of the french instructions? Or would a google translated version of the disclosure work there as well?

@stanislas-m
Copy link
Member

stanislas-m commented Dec 6, 2019 via email

Copy link
Member

@kteb kteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect Thanks.

@kteb kteb merged commit 4cd3ef1 into gobuffalo:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants