Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

went on a bit of a dep diet. 😃 #6

Merged
merged 1 commit into from
Jun 23, 2019
Merged

went on a bit of a dep diet. 😃 #6

merged 1 commit into from
Jun 23, 2019

Conversation

markbates
Copy link
Member

No description provided.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

@@ -1,3 +1,3 @@
package events

const Version = "v1.3.1"
const Version = "v0.0.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "Version" should have comment

Suggested change
const Version = "v0.0.1"
// Version ...
const Version = "v0.0.1"

"strings"
)

var ErrNotFound = fmt.Errorf("not found")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "ErrNotFound" should have comment

Suggested change
var ErrNotFound = fmt.Errorf("not found")
// ErrNotFound ...
var ErrNotFound = fmt.Errorf("not found")


var ErrNotFound = fmt.Errorf("not found")

type Mapi map[string]interface{}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "Mapi" should have comment

Suggested change
type Mapi map[string]interface{}
// Mapi ...
type Mapi map[string]interface{}

return string(b)
}

func (mi Mapi) Interface() interface{} {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "Interface" should have comment

Suggested change
func (mi Mapi) Interface() interface{} {
// Interface ...
func (mi Mapi) Interface() interface{} {

return mi
}

func (mi Mapi) Pluck(s string) (interface{}, error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "Pluck" should have comment

Suggested change
func (mi Mapi) Pluck(s string) (interface{}, error) {
// Pluck ...
func (mi Mapi) Pluck(s string) (interface{}, error) {

return reduce(keys, mi)
}

func (mi *Mapi) UnmarshalJSON(b []byte) error {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "UnmarshalJSON" should have comment

Suggested change
func (mi *Mapi) UnmarshalJSON(b []byte) error {
// UnmarshalJSON ...
func (mi *Mapi) UnmarshalJSON(b []byte) error {

}
}

func (mi Mapi) MarshalJSON() ([]byte, error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported identifier "MarshalJSON" should have comment

Suggested change
func (mi Mapi) MarshalJSON() ([]byte, error) {
// MarshalJSON ...
func (mi Mapi) MarshalJSON() ([]byte, error) {

})
}

// Run the function safely knowing that if it panics
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing comment doesn't match identifier "RunE"

Suggested change
// Run the function safely knowing that if it panics
// RunE the function safely knowing that if it panics

@markbates markbates merged commit fd119c7 into master Jun 23, 2019
@markbates markbates deleted the dep-diet branch June 23, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant