Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added primary_id functionality to the many to many relationship #222

Merged
merged 4 commits into from
Aug 28, 2018

Conversation

Nemesisesq
Copy link
Contributor

The referencing column name can be set using the primary_id tag in the struct.

The reason for this change is that I have two structs that read from the same DB column that have different concerns.

…e referencing column name can be set using the primary_id tag in the struct.

The reason for this change is that I have two structs that read from the same DB column that have different concerns.
@Nemesisesq Nemesisesq requested a review from a team as a code owner August 26, 2018 02:38
@robbyoconnor
Copy link

You will probably also need to update the tests for this.

@robbyoconnor
Copy link

Also, use a topic branch.

Copy link
Member

@mclark4386 mclark4386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the test and the contribution^^

@mclark4386 mclark4386 changed the base branch from master to development August 27, 2018 04:34
@stanislas-m stanislas-m merged commit b72d70d into gobuffalo:development Aug 28, 2018
@stanislas-m stanislas-m added this to the v4.8.0 milestone Sep 5, 2018
mclark4386 pushed a commit that referenced this pull request Sep 28, 2018
* Added primary_id functionality to the many to many relationship so the referencing column name can be set using the primary_id tag in the struct.
The reason for this change is that I have two structs that read from the same DB column that have different concerns.

* Addes tests for the new primary key tag in many_to_many
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants