Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dialect for cockroach and postgresql #324

Merged
merged 5 commits into from
Dec 7, 2018
Merged

Cleanup dialect for cockroach and postgresql #324

merged 5 commits into from
Dec 7, 2018

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Dec 3, 2018 •
edited
Loading

Remove old, dialect side implementation of optionString() from cockroach and uses common OptionsString() implementation for both cockroach and postgresql. (part of #281)

@sio4 sio4 requested a review from a team as a code owner December 3, 2018 07:17
@stanislas-m stanislas-m merged commit b909006 into gobuffalo:development Dec 7, 2018
@sio4 sio4 deleted the cleanup-cockroachdb branch May 17, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislas-m stanislas-m stanislas-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sio4 @stanislas-m