Merge pull request #65 from gobuffalo/task/adding-missing-tests

Adding missing tests for the input hidden
gobuffalo · Jan 25, 2018 · 5949790 · 5949790
2 parents c2176b1 + f7e184e
commit 5949790
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/form/bootstrap/form_for.go b/form/bootstrap/form_for.go
@@ -13,6 +13,7 @@ type FormFor struct {
 	*form.FormFor
 }
 
+//CheckboxTag adds a checkbox to a form
 func (f FormFor) CheckboxTag(field string, opts tags.Options) *tags.Tag {
 	label := field
 	if opts["label"] != nil {

diff --git a/form/form_for_test.go b/form/form_for_test.go
@@ -126,6 +126,13 @@ func Test_FormFor_FieldDoesntExist(t *testing.T) {
 	r.Equal(`<input id="talk-IDontExist" name="IDontExist" type="text" value="" />`, l.String())
 }
 
+func Test_FormFor_HiddenTag(t *testing.T) {
+	r := require.New(t)
+	f := form.NewFormFor(Talk{}, tags.Options{})
+	l := f.HiddenTag("Name", tags.Options{})
+	r.Equal(`<input id="talk-Name" name="Name" type="hidden" value="" />`, l.String())
+}
+
 func Test_FormFor_NullableField(t *testing.T) {
 	r := require.New(t)
 	model := struct {

diff --git a/form/input_tag.go b/form/input_tag.go
@@ -4,9 +4,14 @@ import "github.com/gobuffalo/tags"
 
 //InputTag generates an input tag with passed options, by default will be type=text.
 func (f Form) InputTag(opts tags.Options) *tags.Tag {
+	if opts["type"] == "hidden" {
+		return f.HiddenTag(opts)
+	}
+
 	if opts["type"] == nil {
 		opts["type"] = "text"
 	}
+
 	if opts["type"] == "file" {
 		f.Options["enctype"] = "multipart/form-data"
 	}

diff --git a/form/input_tag_test.go b/form/input_tag_test.go
@@ -43,3 +43,10 @@ func Test_Form_HiddenTag_File(t *testing.T) {
 	i := f.HiddenTag(tags.Options{})
 	r.Equal(`<input type="hidden" />`, i.String())
 }
+
+func Test_Form_InputTag_Hidden(t *testing.T) {
+	r := require.New(t)
+	f := form.New(tags.Options{})
+	i := f.InputTag(tags.Options{"type": "hidden"})
+	r.Equal(`<input type="hidden" />`, i.String())
+}