Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry remove-builtin-method-function branch #719 #747

Merged
merged 2 commits into from
Nov 24, 2018

Conversation

hachi8833
Copy link
Member

@hachi8833 hachi8833 commented Oct 19, 2018

Rebasing #719 is extremely hard so I recreated #719. I hope this would be OK for substitution.

Fortunately, I found some classes such as null.go or regexp.go have not been updated so I updated them as well.

- See #683

- Updated some classes such as null.go, too
@hachi8833 hachi8833 requested a review from st0012 October 19, 2018 02:06
@ghost ghost assigned hachi8833 Oct 19, 2018
@ghost ghost added the in progress label Oct 19, 2018
@hachi8833 hachi8833 changed the title Retry remove-builtin-method-function branch #683 Retry remove-builtin-method-function branch #719 Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #747 into master will decrease coverage by 0.34%.
The diff coverage is 89.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
- Coverage   80.56%   80.22%   -0.35%     
==========================================
  Files          54       54              
  Lines        7452     7323     -129     
==========================================
- Hits         6004     5875     -129     
- Misses       1215     1220       +5     
+ Partials      233      228       -5
Impacted Files Coverage Δ
vm/boolean.go 91.3% <100%> (-1.01%) ⬇️
vm/json.go 85.29% <100%> (-1.01%) ⬇️
vm/concurrent_rw_lock.go 90.9% <100%> (-0.76%) ⬇️
vm/channel.go 88.23% <100%> (-1.24%) ⬇️
vm/go_object.go 15.87% <15.38%> (-6.19%) ⬇️
vm/integer.go 65.52% <57.37%> (-0.64%) ⬇️
vm/match_data.go 66.66% <75%> (-3.04%) ⬇️
vm/uri.go 80.64% <75.6%> (-0.9%) ⬇️
vm/concurrent_array.go 81.81% <78.94%> (-1.52%) ⬇️
vm/float.go 82.01% <80.23%> (-0.75%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d452510...97c5e90. Read the comment docs.

@ghost ghost assigned st0012 Nov 24, 2018
@ghost ghost added the in progress label Nov 24, 2018
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it'll be hard and inefficient to go through each change, I'll trust the test result and squash and merge this.
@hachi8833 thanks for the hard work!

@st0012 st0012 added this to the version 0.1.11 milestone Nov 24, 2018
@st0012 st0012 merged commit 81f9f4d into master Nov 24, 2018
@ghost ghost removed the in progress label Nov 24, 2018
@st0012 st0012 deleted the Remove-builtin-method-function_retry branch November 24, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants