-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove built in methods' function wrapper. #719
Conversation
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 79.72% 79.44% -0.29%
==========================================
Files 53 53
Lines 7355 7252 -103
==========================================
- Hits 5864 5761 -103
- Misses 1240 1244 +4
+ Partials 251 247 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes are nice!
@hachi8833 do you have time to help me rebase this? I'm afraid I might miss some of your changes if I do it myself 😓 |
OK, I'll look into it for rebasing. |
I removed the function wrapper for most class' built-in methods because they are marked as one of the hotspots when profiling. And for most cases, the wrapper function is unnecessary anyway.