fixing types and other #114
Conversation
| @@ -1,7 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "module": "commonjs", | |||
| "moduleResolution": "Node", | |||
There was a problem hiding this comment.
Also forgot: this was duplicated
|
@markrofail-gc Sorry to tag you, just doing it in case you missed this, since these changes are important to merge 🙂 |
| parse, | ||
| InvalidSignatureError, |
There was a problem hiding this comment.
Hi! Why is this error not being retured anymore?
Thanks 🙂
There was a problem hiding this comment.
Sorry, I don't know why GitHub didn't notify me about your reply 🤦♂️
That's a good question (I would have probably a better response three weeks ago), but from what I see I probably thought that it was a mistake (because we would want to export the verifySignature instead of InvalidSignatureError). But if you want to check the error instance somewhere I guess you need that.
I can re-add it back
There was a problem hiding this comment.
@dreinon Done,
Sorry for the late response, I'll double check my github settings 🤦♂️
There was a problem hiding this comment.
Thanks! No worries! We can't do much until the gocardless team replies back haha
There was a problem hiding this comment.
Damn I thought you were on the gocardless team 😭
|
Thanks for the PR and sorry for the lack of activity. As the PR changes the generated code, we cannot accept it, but the issues have been fixed in #122 |
|
@szastupov Thanks for the update. The webhook signature has been fixed with your PR, however, all Any chance you can update this ? |
|
Hi @sambegin! Just want to let you know that we've added fixing union types like |
stringtonumberfor payment (would probably need to be changed for many more) since it fits with your documentation: https://developer.gocardless.com/api-reference/#payments-create-a-payment Everything seems to be numbered, not string, why keeping string in types :) ?