Do not allow all-0 account numbers for CA; refactor all-0 check for AU #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeSouthan
reviewed
Oct 2, 2023
lib/ibandit/iban.rb
Outdated
| @@ -294,7 +294,6 @@ def passes_country_specific_checks? | |||
| case country_code | |||
| when "DE" then supports_iban_determination? | |||
| when "SE" then valid_swedish_details? | |||
| when "AU" then valid_australian_details? | |||
There was a problem hiding this comment.
Why has this been deleted?
There was a problem hiding this comment.
Well.. This is what happens when you forget to self-review your PRs...
JoeSouthan
approved these changes
Oct 2, 2023
rrundzansgc
changed the title
rrundzansgc
force-pushed
the
ca_improvements
branch
from
18e5061
to
cbcef0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All-zero CA bank account numbers like 0000000 or 000000000000 should be treated as invalid.