Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml.NodeToValue(ast.Node, interface{}, ...DecodeOption) error #236

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

zoncoen
Copy link
Contributor

@zoncoen zoncoen commented Jul 19, 2021

go-yaml can convert a value to an AST node by ValueToNode. This PR adds the opposite function NodeToValue.

@zoncoen zoncoen force-pushed the node-to-value branch 2 times, most recently from fd07a8d to 3f76810 Compare July 19, 2021 12:13
@codecov-commenter
Copy link

Codecov Report

Merging #236 (f6a3c23) into master (88ebfa0) will increase coverage by 0.04%.
The diff coverage is 64.70%.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   78.78%   78.83%   +0.04%     
==========================================
  Files          12       12              
  Lines        3338     3355      +17     
==========================================
+ Hits         2630     2645      +15     
+ Misses        483      482       -1     
- Partials      225      228       +3     

@goccy
Copy link
Owner

goccy commented Jul 19, 2021

Thank you for the awesome PR !! This is perfect !

@goccy goccy merged commit 2c8e5ef into goccy:master Jul 19, 2021
@zoncoen zoncoen deleted the node-to-value branch July 19, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants