Fix error reporting on inline structs in strict mode (#243) #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 12 12
Lines 3417 3417
=======================================
Hits 2678 2678
Misses 505 505
Partials 234 234 |
|
This fixes unmarshaling errors but I also need to separate fix validation for inline structs; right now validation isn't being checked because unexpected fields are being checked first (and then discarded). Working on another commit to fix validation. |
|
Thank you for the contribution ! LGTM ! |
|
Ah, you didn't wait for my subsequent commit. :) I'll open another PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors from inline structs were getting lost in strict mode.