Fixed the vsm pin issue. The VSM pin is represented by an icon. There…

… is no need for the button text.(#3775) * The css property text_indent is provided on unnecessary texts like stage name, material icon. This commit removes that.
gocd · Jun 19, 2018 · 44264c3 · 44264c3
1 parent 70c104a
commit 44264c3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 15 deletions.
diff --git a/server/webapp/WEB-INF/rails.new/app/assets/javascripts/vsm_renderer.js b/server/webapp/WEB-INF/rails.new/app/assets/javascripts/vsm_renderer.js
@@ -122,7 +122,7 @@ Graph_Renderer = function (container) {
             }
 
             gui += '<div class="actions">';
-            gui += '<button class="pin" title="Keep dependencies highlighted">pin</button>';
+            gui += '<button class="pin" title="Keep dependencies highlighted" />';
             gui += '</div>';
 
             return gui;
@@ -283,7 +283,7 @@ Graph_Renderer = function (container) {
                 gui += '">' + (node.instances.length - 1) + ' more...</a></div>';
             }
         }
-        gui += '<div class="actions"><button class="pin" title="Keep dependencies highlighted">pin</button></div>';
+        gui += '<div class="actions"><button class="pin" title="Keep dependencies highlighted" /></div>';
         return gui;
     }
 
@@ -293,7 +293,7 @@ Graph_Renderer = function (container) {
         if (node.message) {
             gui += '<div class="message restricted"><span>' + node.message + '</span></div>';
         }
-        gui += '<div class="actions restricted"><button class="pin" title="Keep dependencies highlighted">pin</button></div>';
+        gui += '<div class="actions restricted"><button class="pin" title="Keep dependencies highlighted" /></div>';
         return gui;
     }
 
@@ -311,7 +311,7 @@ Graph_Renderer = function (container) {
         if (node.message) {
             gui += '<div class="message deleted"><span>' + node.message + '</span></div>';
         }
-        gui += '<div class="actions deleted"><button class="pin" title="Keep dependencies highlighted">pin</button></div>';
+        gui += '<div class="actions deleted"><button class="pin" title="Keep dependencies highlighted" /></div>';
         return gui;
     }
 
@@ -338,14 +338,14 @@ Graph_Renderer = function (container) {
                 gui += '<li class="stage_bar ';
                 gui += ((instance.stages[i].status != undefined) ? instance.stages[i].status : 'Unknown');
                 if (instance.stages[i].status == 'Unknown') {
-                    gui += '" style="width:' + ((stagesWidth - (stagesCount * 4)) / stagesCount) + 'px" title="' + instance.stages[i].name + '"><span>' + instance.stages[i].name + '</span></li>'
+                    gui += '" style="width:' + ((stagesWidth - (stagesCount * 4)) / stagesCount) + 'px" title="' + instance.stages[i].name + '"></li>'
                 }
                 else {
                   var stageTitle = instance.stages[i].name;
                   if(_.toInteger(instance.stages[i].duration) > 0){
                     stageTitle += ' (took ' + moment.duration(instance.stages[i].duration, 's').humanizeForGoCD() + ')';
                   }
-                  gui += '" style="width:' + ((stagesWidth - (stagesCount * 4)) / stagesCount) + 'px" title="' + stageTitle + '"><span><span></span></span><a href="' + instance.stages[i].locator + '"><span>' + instance.stages[i].name + '</span></a></li>'
+                  gui += '" style="width:' + ((stagesWidth - (stagesCount * 4)) / stagesCount) + 'px" title="' + stageTitle + '"><span><span></span></span><a href="' + instance.stages[i].locator + '"></a></li>'
                 }
             }
             gui += '</ul>';

diff --git a/server/webapp/WEB-INF/rails.new/app/assets/stylesheets/module.scss b/server/webapp/WEB-INF/rails.new/app/assets/stylesheets/module.scss
@@ -2645,7 +2645,6 @@ li.task_property {
     background: image_url('andare/ico-16x16.png') no-repeat scroll 0px -20px transparent;
     display: inline-block;
     padding: 0 0 5px 18px;
-    text-indent: -6000px;
 }
 
 .vsm-entity .show-more {
@@ -2775,7 +2774,6 @@ li.task_property {
 .vsm-entity.pipeline .stages {
     white-space: normal;
     margin-right: -4px;
-    text-indent: -6000px;
     float: none;
 }
 .vsm-entity.pipeline .stages li {
@@ -2908,12 +2906,6 @@ li.task_property {
     z-index: 1;
 }
 
-.vsm-entity.material .icon {
-    width: 16px;
-    height: 16px;
-    text-indent: -6000px;
-}
-
 .vsm-entity.material .actions {
     bottom: 0 ;
     text-align: center;
@@ -3070,7 +3062,6 @@ li.task_property {
     height: 16px;
     float: right;
     background: image_url('andare/ico-16x16.png') no-repeat scroll 0px -140px transparent;
-    text-indent: -6000px;
     margin: 8px 5px 5px 0px;
 }