UI Issues for 18.12

[akshaydewan]

This issue to track all the UI issues that need be fixed for the 18.12 release, so that we can prioritize things easily, and so that it's easier for @naveenbhaskar to keep track.

• Config Repo forms layout needs to be fixed
• Size of modals needs to be tweaked (there is too much white space either at the bottom or right side)
• Add Data Sharing to the new Menu
• Make Config Repo delete confirmation modal Small
• Fix for long text in key-value-pair component
• Feedback for the new Menu - the Security section seems odd.
• For Internet Explorer 11 users, we need to show a message saying that the browser is not supported
• UI for notifying users that Drain Mode is active
• Revisit "danger button" color.
• Move plugin ID from top into the details section on plugins SPA page.
• Fix broken headers in history and Job details page
• Inconsistent highlighting for menu items under admin (UI Issues for 18.12 #5464 (comment))
• 'Admin' menu is not clickable or hoverable on IE edge browser.
• 'GoCD YAML files pattern:' field is not displaying on expanding config repo even though it has a values.
• On config repo spa , after couple of seconds, a same config repo displaying multiple times.

[rahulpargaonkar]

Adding some UI issues on plugins page & config repo spa page

1. on plugins page, irregular spacing between plugin names & ids

2. on config_repo SPA page, error symbol is miss-aligned on plugins page, it looks incorrect as compared to green tick symbol.

3. on config repo add/edit pop-up window, a text box sized window is highlighted when a checkbox is selected or not- selected.

4. when config repo expanded the the username is diplayed as null if not provided. Instead of null, can we specify either 'not specified'? or hide it? Or may be we can make username and password field interdependent?

[ibnc]

I've noticed an issue with the dashboard tabs on build.gocd.org. When I click the Go icon on the top left, it takes me back to the furthest left tab, but the content of the page is incorrect.

Screenshot 1:

Screenshot 2:

[rahulpargaonkar]

@ibnc I am not able to reproduce the issue on build.gocd and on locally. could you please provide the gif of issue?

[rahulpargaonkar]

UI Issue 5: unnecessary whitespace coming on delete config repo pop-up.

Edit: Should be fixed now - Akshay

[rahulpargaonkar]

Issue 6: correct (green tick) icon is displayed even though the parsing error is there in config repo.

Edit: Should be fixed now -Akshay

[vishaldevgire]

UI Issue 7: When using , long key names and values overlap

[ibnc]

@rahulpargaonkar Here's a gif of the issue I see:

Chrome version: 70.0.3538.102

[rajiesh]

UI Issue 8:

ADMIN link visible for view users. On the GoCD server build : 18.12.0 (8092-8b8ef0cf42f2186aa73a0a7074e669fa2c70655d) Login as view user and observe that ADMIN link is visible on the header, however the admin menu is disabled. Prefer to disable it for the view users

[rajiesh]

UI Issue 9:

On server setup with analytics plugin, ANALYTICS option on page header is visible on rails pages like Stage/Job details page, compare build page and other pages for non admin users.

[maheshp]

@rajiesh I am looking into Issue 8 & 9.

[vishaldevgire]

UI issue 10:

One Elastic Profile component SPA, while creating or editing profile the Id text field is not aligned properly to other form elements.

[rajiesh]

While discussing on the UI issues on Plugins SPA page with componentization - there came up a suggestion to remove Id field from top level and move it to the details section of each plugin so that we get more space for plugin name and Version can be aligned similarly for all plugins in the list. Adding it as an item to the issue

cc: @akshaydewan @maheshp

[rajiesh]

@ibnc We moved the issue you reported related to dashboard personalization view not showing correct set of pipelines to #5512 since we are addressing it separately. Please check and add if missed any info

[rajiesh]

Headers are broken on History page and Job details page. Its observed on version 18.12.0 (8139-005f4fd80bafd2efd1d413537368156303f6ef6e)

[akshaydewan]

@rajiesh I'm looking into the broken header

Edit: fixed via #5525

[varshavaradarajan]

Some links in the dropdown menu are in gray until you access them. Eg - role configuration, data sharing. Pipelines, package repositories were also gray until I clicked on them and then came back to the dashboard. Is this intentional, @akshaydewan ?

[naveenbhaskar]

@varshavaradarajan .. not intentional , will fix that

[GaneshSPatil]

Extra whitespaces on all the modals.

this is broken due to c27c94a

IMO, setting min height on the modal-body will cause these issues at many places, if a specific modal-body element requires min-height, we should wrap it inside a wrapper container and add min-height to the wrapper container.

\cc: @akshaydewan @naveenbhaskar

[varshavaradarajan]

Elastic agent profile view for K8s elastic agent is screwed up. Not sure if this belongs here though.

[rahulpargaonkar]

issue 15: On config repo spa , after couple of seconds, a same config repo displaying multiple times.
console log showing a below mentioned error

   mithril.js:485 Uncaught TypeError: Cannot read property 'view' of undefined
   at c (mithril.js:485)
   at mithril.js:505
   at u (mithril.js:421)
   at s (mithril.js:405)
   at mithril.js:477
   at u (mithril.js:418)
   at s (mithril.js:405)
   at mithril.js:477
   at u (mithril.js:418)
   at s (mithril.js:405)

[arvindsv]

On 18.12.0 (8203-bbeebad6c03497cf3f5bf0bcddbe13bbc08a11c8, I see this:

The font size of the red warning div is more than it should be.

---

Also on 18.12.0 (8203-bbeebad6c03497cf3f5bf0bcddbe13bbc08a11c8:

The filter history text box is not aligned.

[adityasood]

verified by @rahulpargaonkar on 18.12.0-8222