Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin request processor versioning #5653

Closed
maheshp opened this issue Jan 3, 2019 · 0 comments
Closed

Plugin request processor versioning #5653

maheshp opened this issue Jan 3, 2019 · 0 comments
Milestone
Release 19.1.0

Comments

@maheshp
Copy link
Contributor

maheshp commented Jan 3, 2019

Issue Type
  • Feature enhancement
Summary

Plugins can make a request to the GoCD server through multiple endpoints. These requests from plugins are handled by various RequestProcessors based on the request. There seems to be some inconsistency in the way the endpoints are versioned and also ambiguity of which version to use due to lack of better documentation.

Also, some of the RequestProcessors rely on the Plugin API version and depend on the plugin extensions for serializing of these messages. The Plugin API version should be independent of the version of the endpoints exposed by GoCD to the plugins.

Ensure all endpoints exposed to the plugin are versioned and documented separately in plugin-api.gocd.org.
@maheshp maheshp added this to the Release 19.1.0 milestone Jan 3, 2019
maheshp added a commit to maheshp/gocd that referenced this issue Jan 3, 2019
@maheshp
ServerInfo request processor does not delegate serialization to exten…
ebbf4ec 
…sions gocd#5653
@maheshp maheshp mentioned this issue Jan 3, 2019
Merged
maheshp added a commit to maheshp/gocd that referenced this issue Jan 4, 2019
@maheshp
PluginSettings request processor does not delegate serialization to e…
2e8a970 
…xtensions gocd#5653
maheshp added a commit to maheshp/gocd that referenced this issue Jan 4, 2019
@maheshp
ServerInfo request processor does not delegate serialization to exten…
fed3f73 
…sions gocd#5653
maheshp added a commit to maheshp/gocd that referenced this issue Jan 4, 2019
@maheshp
PluginSettings request processor does not delegate serialization to e…
ee53e23 
…xtensions gocd#5653
maheshp added a commit to maheshp/gocd that referenced this issue Jan 4, 2019
@maheshp
ServerInfo request processor does not delegate serialization to exten…
d68f283 
…sions gocd#5653
maheshp added a commit to maheshp/gocd that referenced this issue Jan 4, 2019
@maheshp
PluginSettings request processor does not delegate serialization to e…
67963f7 
…xtensions gocd#5653
maheshp added a commit to maheshp/gocd that referenced this issue Jan 7, 2019
@maheshp
ServerInfo request processor does not delegate serialization to exten…
143054f 
…sions gocd#5653
maheshp added a commit to maheshp/gocd that referenced this issue Jan 7, 2019
@maheshp
PluginSettings request processor does not delegate serialization to e…
1566e77 
…xtensions gocd#5653
@maheshp maheshp reopened this Jan 8, 2019
maheshp added a commit to maheshp/plugin-api.go.cd that referenced this issue Jan 14, 2019
@maheshp
Document the API version for all the application_accessor endpoints
9004246 
* The API version for the application_accessor was not explicitly
  documented which lead to ambguity. Explicitly setting the API version
  for each accessor endpoint.
* Refer gocd/gocd#5653
@maheshp maheshp mentioned this issue Jan 14, 2019
Merged
@rajiesh rajiesh closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 19.1.0
Development

No branches or pull requests
2 participants
@maheshp @rajiesh