Do not start service on a new install. Allow users to configure the agent and server and have them start it up. (#3119) #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the diff of the package scripts on debian — https://gist.github.com/ketan/460271873845ad46d897015f15b48dbe Here's the diff of the package scripts on RPMS — https://gist.github.com/ketan/80cd68bc1eea627d80c0eea877fe8bfc/revisions |
server/config/cruise-config.xml
Outdated
| @@ -1,28 +1,80 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <cruise xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="cruise-config.xsd" schemaVersion="87"> | |||
| <cruise xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="cruise-config.xsd" schemaVersion="88"> | |||
There was a problem hiding this comment.
This file shouldn't be checked in, right?
There was a problem hiding this comment.
Probably not as part of this PR. But if we bump the version, we should just check this file in.
There was a problem hiding this comment.
Sure. Its already done though. https://github.com/gocd/gocd/blob/master/server/config/cruise-config.xml#L2
…gent and server and have them start it up. (gocd#3119)
ketan
force-pushed
the
fix/prevent-linux-service-startup
branch
from
1d4044f
to
3b9f54b
Compare
|
Pending: Show a post install message on fresh install of the go server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.