[Environment API Spark]: Compute MergedEnvironmentConfig etag using Objects.hash
#5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `getEnvironments` method instead of `getAllMergedEnvironments` to get all environment for index call. - Use `getEnvironmentConfig` instead of `getMergedEnvironmentforDisplay` to find environment by name.
- This is done as Environment coming from config repo represeted using MergedEnvironmentConfig object and caculating etag for none config entity is not supported by entity hashing service. - Here we have used `Objects.hash(...)` which generates identical hash for same valued objects.
…onse as well as for Etag computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #5807
Summary
Environment coming from config repo is represented using
MergedEnvironmentConfig. TheEntityHashingServiceis calculating hashes only for the config entities. AsMergedEnvironmentConfigis not a config entity it fails to detect@ConfigTagannotation and fails to generate md5.In ruby, we calculate the md5 on generated JSON payload for index calls.
Fix
Calculate md5 using object hash.
This is done as Environment coming from config repo represented using
MergedEnvironmentConfig object and calculating Etag for none config
the entity is not supported by entity hashing service.
Here we have used
Objects.hash(...)which generates an identical hashfor the same valued objects.
Sort the EnvironmentConfigs by name to guaranty the order in the response as well as for Etag computation.