Support for secret param in material #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshp
reviewed
Mar 18, 2019
| @@ -140,7 +140,7 @@ private BuildCommand cleanWorkingDir(String workDir) { | |||
|
|
|||
| private BuildCommand isRepoUrlChanged(String workDir) { | |||
| return test("-neq", | |||
| material.getUrlArgument().forCommandline(), | |||
| material.getUrlArgument().rawUrl(), | |||
There was a problem hiding this comment.
This should be changed back to forCommandline()
maheshp
reviewed
Mar 18, 2019
| @@ -159,7 +159,7 @@ private BuildCommand cmdClone(String workDir, int cloneDepth) { | |||
| if (material.isShallowClone()) { | |||
| cloneArgs.add(format("--depth=%s", String.valueOf(cloneDepth))); | |||
| } | |||
| cloneArgs.add(material.getUrlArgument().forCommandline()); | |||
| cloneArgs.add(material.getUrlArgument().rawUrl()); | |||
There was a problem hiding this comment.
This should be changed back to forCommandline()
bdpiprava
force-pushed
the
support_for_scret_param_in_material
branch
4 times, most recently
from
3843534
to
bc026f8
Compare
maheshp
reviewed
Mar 20, 2019
| public String forDisplay() { | ||
| if (hasSecretParams()) { |
There was a problem hiding this comment.
We might have to change this, e.g https://#{SECRET[id][key]}:password@foo.com/bar.git how will this be handled?
bdpiprava
force-pushed
the
support_for_scret_param_in_material
branch
5 times, most recently
from
5a3c97e
to
a6c19ac
Compare
…CommandLine, forDisplay for secret param
bdpiprava
force-pushed
the
support_for_scret_param_in_material
branch
from
a6c19ac
to
e2dcab4
Compare
naveenbhaskar
pushed a commit
to naveenbhaskar/gocd
that referenced
this pull request
Mar 28, 2019
* Added method `rawUrl` in CommandArgument to get unresolved url. * Updated usages of getUrl and forCommandLine * Moving to use junit5. It was reverted back to junit4 in PR gocd#5964. * Update UrlArgument to return appropraite value as part of rawUrl, forCommandLine, forDisplay for secret param * Renamed rawUrl to originalArgument * Use urlForCommandLine at appropreate places. * Resolve secret params on post commit hook. * Adding secret param support for material password. * Resolve secret params for materials before build assignment to agent * Changed secret param template to `${SECRET[][]}` from '#{SECRET[][]}` * Removed deadcode. * Changed Secrets params format to '{{SECRET:[][]}}' * Always parse the password configured in material * Fixed few test failures
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link to issue #6014
UrlArgumentto support originalValue, urlForCommandLine and forDisplay.#{SECRET[][]}to{{SECRET:[][]}}