Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new pipeline create flow should check for group admin as well #6404

Merged
merged 2 commits into from Jun 13, 2019
Merged

The new pipeline create flow should check for group admin as well #6404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5880286
The new pipeline create flow should check for group admin as well
kritika-singh3 Jun 10, 2019
9349819
Added tests for PipelinesController
kritika-singh3 Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion spark/spark-spa/src/main/java/com/thoughtworks/go/spark/spa/PipelinesController.java
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ public String controllerBasePath() {
@Override
public void setupRoutes() {
path(controllerBasePath(), () -> {
before("", authenticationHelper::checkAdminUserAnd403);
before("", authenticationHelper::checkAdminUserOrGroupAdminUserAnd403);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are there now in spark/spark-spa/src/test/groovy/com/thoughtworks/go/spark/spa/PipelinesControllerTest.groovy:

    @Nested
    class Security implements SecurityTestTrait, GroupAdminUserSecurity { ... }

get("", this::index, engine);
});
}
Expand Down